Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite multifield: Underscore dependency missing #3333

Closed
roszpapad opened this issue May 3, 2024 · 4 comments · Fixed by #3335
Closed

Composite multifield: Underscore dependency missing #3333

roszpapad opened this issue May 3, 2024 · 4 comments · Fixed by #3335
Milestone

Comments

@roszpapad
Copy link
Contributor

AEM version: 6.5.20
ACS AEM Commons Version: 6.3.2
Reproducible on Latest? yes

Expected Behavior

There is no JS error in the console.

Actual Behavior

Current error in the console:
image

The issue is caused by window._ is undefined. /apps/acs-commons/touchui-widgets/composite-multifield and more touch-ui widgets depend on lodash.underscore which is not found in AEM 6.5.20. Therefore, we always get this issue. A potential fix would be to depend on acs-commons.lodash instead (/apps/acs-commons/clientlibs/vendor/lodash) or depend on cq.integ.underscore (/libs/cq/personalization/clientlib/underscore)

Steps to Reproduce

Embed acs-commons.authoring.composite-multifield clientlib. If you open a dialog, the JS issue will appear.

Note: /apps/acs-commons/touchui-widgets/search-based-path-browser also depends on lodash.underscore.

@roszpapad
Copy link
Contributor Author

FYI The same issue was fixed in #2821 by introducing lodash.underscore. But this category is not working anymore.

@roszpapad
Copy link
Contributor Author

I am closing this issue because in the end, it seems that some of our customizations broke this functionality. I will reopen this if it is not the case.

@roszpapad
Copy link
Contributor Author

I am reopening the issue. I double-checked it and the issue is with the dependency of composite-multifield. On my local environment, I changed it manually to acs-commons.lodash and the issue was gone. Can you please double-check it on your side as well?

@roszpapad roszpapad reopened this May 3, 2024
roszpapad added a commit to roszpapad/acs-aem-commons that referenced this issue May 3, 2024
@kwin kwin added this to the 6.6.2 milestone May 3, 2024
@kwin
Copy link
Contributor

kwin commented May 3, 2024

FTR: According to https://experienceleague.adobe.com/en/docs/experience-manager-65/content/release-notes/deprecated-removed-features

Deprecated Feature: Lodash/underscore client library. Adobe does not plan to further maintain and update the Lodash/underscore client library that is shipped as part of the distribution (Quickstart).

Replacement: Adobe recommends customers that still require Lodash/underscore for their code to add it into their project code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants