-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite multifield: Underscore dependency missing #3333
Comments
FYI The same issue was fixed in #2821 by introducing lodash.underscore. But this category is not working anymore. |
I am closing this issue because in the end, it seems that some of our customizations broke this functionality. I will reopen this if it is not the case. |
I am reopening the issue. I double-checked it and the issue is with the dependency of composite-multifield. On my local environment, I changed it manually to |
FTR: According to https://experienceleague.adobe.com/en/docs/experience-manager-65/content/release-notes/deprecated-removed-features
|
AEM version: 6.5.20
ACS AEM Commons Version: 6.3.2
Reproducible on Latest? yes
Expected Behavior
There is no JS error in the console.
Actual Behavior
Current error in the console:
![image](https://private-user-images.githubusercontent.com/32868620/327737115-5a7d9fc2-e9e9-43f2-92ee-fae2b3abb8e6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk3NzkyNTEsIm5iZiI6MTcxOTc3ODk1MSwicGF0aCI6Ii8zMjg2ODYyMC8zMjc3MzcxMTUtNWE3ZDlmYzItZTllOS00M2YyLTkyZWUtZmFlMmIzYWJiOGU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjMwVDIwMjIzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBhZGFkNmQ5MWFlZWY0OTQzYmJhZGQ2NjM2MWMyMDM5MGYwY2M1MjU4YjE5MTQwM2NhNWRmNTNlZDcxN2VjMjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.M_3OKe92FsLd64Kx-EZ_XpSPl8VYPf93uW1bMGX8Ya8)
The issue is caused by
window._
is undefined. /apps/acs-commons/touchui-widgets/composite-multifield and more touch-ui widgets depend on lodash.underscore which is not found in AEM 6.5.20. Therefore, we always get this issue. A potential fix would be to depend on acs-commons.lodash instead (/apps/acs-commons/clientlibs/vendor/lodash) or depend on cq.integ.underscore (/libs/cq/personalization/clientlib/underscore)Steps to Reproduce
Embed acs-commons.authoring.composite-multifield clientlib. If you open a dialog, the JS issue will appear.
Note: /apps/acs-commons/touchui-widgets/search-based-path-browser also depends on lodash.underscore.
The text was updated successfully, but these errors were encountered: