Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegating Servlet issues in AEM 6.1 #685

Closed
davidjgonzalez opened this issue Apr 12, 2016 · 2 comments
Closed

Delegating Servlet issues in AEM 6.1 #685

davidjgonzalez opened this issue Apr 12, 2016 · 2 comments

Comments

@davidjgonzalez
Copy link
Contributor

Moving to GH for visibility from Brett Birschbach: http://adobe-consulting-services.github.io/acs-aem-commons/features/delegating-servlet.html#comment-2613784251

I tested this on AEM 6.1 for the use case of "Moving resource type implementations without modifying all content sling:resourceType properties." I ran into several issues and am curious if anyone has any input.

In my example I changed a "hero" component to "hero-changed". Note that I did test all scenarios with new instances of the "hero-changed" component to verify that I have that component configured correctly. The issues below all involve rendering the old "hero" component instances which are being mapped to "hero-changed" by the DelegatingServlet.

  • Instances of the old "hero" resourceType will render on the page, but they will not include the CSS class (.hero-changed) in the HTML for the component. As such, component styling is not picked up.
  • Instances of the old "hero" resourceType do not have a dialog on the touch UI and thus cannot be configured/updated.
  • At times the rendering of the old "hero" components fails if the component is sufficiently far enough down the page to trigger "java.lang.IllegalStateException: Response already committed"
  • At times (I'm not sure the full cause) an old "hero" component on the page causes some of the page HTML to simply be missing at the top of the page, completely breaking the page. This happened when attempting to use the classic authoring UI, but also in other cases.

One other "gotcha" for those using the DelegatingServlet for this use case:

  • Initially the background image from the DAM for the old "hero" instances were not successfully rendered. That's because I had configured the DelegatingServlet with the default extension of ".html". For the image connected to the component to render correctly, I needed to also add ".png" as an extension. In practice, it looks like I would need to add every possible image extension to be safe.
@HitmanInWis
Copy link
Contributor

Thanks David!

@stale stale bot added the wontfix label Sep 15, 2017
@stale
Copy link

stale bot commented Sep 15, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants