Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granite Select Filter #1894

Conversation

ahmed-musallam
Copy link
Contributor

@ahmed-musallam ahmed-musallam commented May 14, 2019

This PR is for feature #1880

Adds a filter field to Granite Select

The Granite widget must have the data attribute: data-acs-select-filter

Sample dialog field XML:

note the acs-select-filter="true" in the granite:data node
more on granite:data here

<listFrom jcr:primaryType="nt:unstructured" fieldLabel="Build List Using" granite:class="cq-dialog-dropdown-showhide" name="./listFrom" sling:resourceType="granite/ui/components/coral/foundation/form/select">
        <granite:data jcr:primaryType="nt:unstructured" acs-select-filter="true" cq-dialog-dropdown-showhide-target=".list-option-listfrom-showhide-target"/>
        <items jcr:primaryType="nt:unstructured">
            <children jcr:primaryType="nt:unstructured" granite:hide="${cqDesign.disableChildren}" text="Child pages" value="children"/>
            <static jcr:primaryType="nt:unstructured" granite:hide="${cqDesign.disableStatic}" text="Fixed list" value="static"/>
            <search jcr:primaryType="nt:unstructured" granite:hide="${cqDesign.disableSearch}" text="Search" value="search"/>
            <tags jcr:primaryType="nt:unstructured" granite:hide="${cqDesign.disableTags}" text="Tags" value="tags"/>
        </items>
    </listFrom>

@update-changelog
Copy link

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request.

@coveralls
Copy link

coveralls commented May 14, 2019

Pull Request Test Coverage Report for Build 4362

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.22%

Totals Coverage Status
Change from base Build 4354: 0.0%
Covered Lines: 13115
Relevant Lines: 25115

💛 - Coveralls

Copy link
Contributor

@klcodanr klcodanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmed-musallam, could you update the CHANGES file for this?

@ahmed-musallam
Copy link
Contributor Author

@klcodanr done.

@klcodanr klcodanr merged commit 09191d0 into Adobe-Consulting-Services:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants