Switch from m-scr-p and m-bundle-p to bnd-m-p #2761
Conversation
| entry = zis.getNextEntry(); | ||
| } | ||
| } | ||
| // metatype descriptors must come last (after component descriptions) |
There was a problem hiding this comment.
@justinedelson Any reason why you think that metatype attributes should overwrite the value of same named component properties? IMHO those two are not directly related. Currently it feels a bit like we a comparing apples and pears. The correct way would be to compare SCR descriptors and metatype descriptors separately, as one affects the default properties of DS components, the other one only how the Felix Web Console renders a UI for setting custom properties.
There was a problem hiding this comment.
This may easily lead to false positives e.g. in case you change the component property to another type while keeping the metatype with the previous type.
Codecov Report
@@ Coverage Diff @@
## master #2761 +/- ##
=========================================
Coverage ? 53.79%
Complexity ? 5528
=========================================
Files ? 752
Lines ? 30455
Branches ? 3936
=========================================
Hits ? 16383
Misses ? 12545
Partials ? 1527
Continue to review full report at Codecov.
|
kwin
force-pushed
the
feature/bnd-maven-plugin
branch
2 times, most recently
from
7c88e0d
to
31f954c
Compare
This closes #1718 Still WIP
make ScrMetadataIT more robust by not relying on order in JAR ease debugging by prefixing property values coming from metatype with "(metatype)"
kwin
force-pushed
the
feature/bnd-maven-plugin
branch
from
31f954c
to
7f4544b
Compare
|
@davidjgonzalez Can you review? I would like to merge soon... |
This closes #1718