Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page property injection #3160

Conversation

royteeuwen
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #3160 (ef2668b) into master (4be29a1) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 83.33%.

❗ Current head ef2668b differs from pull request most recent head ee6c7a4. Consider uploading reports for the commit ee6c7a4 to get more accurate results

@@            Coverage Diff            @@
##             master    #3160   +/-   ##
=========================================
  Coverage     55.20%   55.20%           
- Complexity     5419     5422    +3     
=========================================
  Files           711      711           
  Lines         29030    29032    +2     
  Branches       3759     3760    +1     
=========================================
+ Hits          16026    16028    +2     
  Misses        11496    11496           
  Partials       1508     1508           
Files Changed Coverage Δ
...jectors/impl/HierarchicalPagePropertyInjector.java 60.00% <83.33%> (+6.15%) ⬆️

@royteeuwen
Copy link
Contributor Author

@davidjgonzalez could I get a review for this :) ?

@davidjgonzalez davidjgonzalez added this to the 6.1.0 milestone Aug 30, 2023
@davidjgonzalez davidjgonzalez merged commit ad10e45 into Adobe-Consulting-Services:master Sep 8, 2023
9 of 10 checks passed
YegorKozlov pushed a commit to YegorKozlov/acs-aem-commons that referenced this pull request Oct 19, 2023
* Add page property injection
---------

Co-authored-by: Roy Teeuwen <c-roy.teeuwen@acolad.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants