Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure Component/BundleDisabler via Configuration Factories #3266

Merged
merged 2 commits into from Mar 22, 2024

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Feb 23, 2024

This allows them to be no longer singletons.
Migrate to OSGi DS/Metatype annotations.
Cleanup of Javadoc.

This closes #3262

@kwin
Copy link
Contributor Author

kwin commented Feb 23, 2024

I am still in clarification if a component should be usable both through factory configurations and regular configurations (for backwards-compatibility reasons): bndtools/bnd#6042.

@stbischof
Copy link

stbischof commented Feb 23, 2024

But why do you need a factory.pid and a pid?

Just use a normal pid and make the conponent required. Will work same.
You can use every pid in configadmin to make a factory pid fron it.

Why do you want to have it immidiate and required?

@kwin kwin force-pushed the feature/component-bundle-disabler-as-factory branch 2 times, most recently from 9b54383 to 2b49648 Compare February 23, 2024 19:31
@kwin
Copy link
Contributor Author

kwin commented Feb 23, 2024

You can use every pid in configadmin to make a factory pid fron it.

This is about the metatype being created. If it doesn't have both delegate for factory and non factory PID it won't be exposed correctly in Felix Web Console UI.

@kwin kwin force-pushed the feature/component-bundle-disabler-as-factory branch from 2b49648 to e734681 Compare February 23, 2024 19:54
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 30.43478% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 55.43%. Comparing base (dc54035) to head (9683835).
Report is 4 commits behind head on master.

❗ Current head 9683835 differs from pull request most recent head 4f0d77b. Consider uploading reports for the commit 4f0d77b to get more accurate results

Files Patch % Lines
...adobe/acs/commons/util/impl/ComponentDisabler.java 0.00% 12 Missing ⚠️
...om/adobe/acs/commons/util/impl/BundleDisabler.java 63.63% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3266      +/-   ##
============================================
- Coverage     55.45%   55.43%   -0.03%     
+ Complexity     5506     5504       -2     
============================================
  Files           721      721              
  Lines         29534    29545      +11     
  Branches       3840     3840              
============================================
- Hits          16378    16377       -1     
- Misses        11630    11642      +12     
  Partials       1526     1526              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kwin kwin marked this pull request as ready for review February 23, 2024 20:21
@kwin kwin force-pushed the feature/component-bundle-disabler-as-factory branch from e734681 to 5354685 Compare February 23, 2024 20:25
@stbischof
Copy link

But isnt that a Missing Feature of webconsole.
There should also be normal pids be configurable .

@kwin kwin force-pushed the feature/component-bundle-disabler-as-factory branch 3 times, most recently from 09eba48 to 856f9a7 Compare February 24, 2024 18:59
@kwin kwin force-pushed the feature/component-bundle-disabler-as-factory branch from 856f9a7 to c522c3e Compare March 8, 2024 18:46
Migrate to OSGi DS/Metatype annotations.
Cleanup of Javadoc.

This closes #3262
@kwin kwin force-pushed the feature/component-bundle-disabler-as-factory branch from c522c3e to 9683835 Compare March 18, 2024 18:53
@davidjgonzalez davidjgonzalez merged commit 7047719 into master Mar 22, 2024
9 of 10 checks passed
YegorKozlov pushed a commit to YegorKozlov/acs-aem-commons that referenced this pull request Mar 25, 2024
…es (Adobe-Consulting-Services#3266)

Migrate to OSGi DS/Metatype annotations.
Cleanup of Javadoc.

This closes Adobe-Consulting-Services#3262

Co-authored-by: david g <davidjgonzalez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow usage of BundleDisabler and ComponentDisabler via factory configuration
3 participants