-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configure Component/BundleDisabler via Configuration Factories #3266
Allow to configure Component/BundleDisabler via Configuration Factories #3266
Conversation
I am still in clarification if a component should be usable both through factory configurations and regular configurations (for backwards-compatibility reasons): bndtools/bnd#6042. |
But why do you need a factory.pid and a pid? Just use a normal pid and make the conponent required. Will work same. Why do you want to have it immidiate and required? |
9b54383
to
2b49648
Compare
This is about the metatype being created. If it doesn't have both delegate for factory and non factory PID it won't be exposed correctly in Felix Web Console UI. |
2b49648
to
e734681
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3266 +/- ##
============================================
- Coverage 55.45% 55.43% -0.03%
+ Complexity 5506 5504 -2
============================================
Files 721 721
Lines 29534 29545 +11
Branches 3840 3840
============================================
- Hits 16378 16377 -1
- Misses 11630 11642 +12
Partials 1526 1526 ☔ View full report in Codecov by Sentry. |
e734681
to
5354685
Compare
But isnt that a Missing Feature of webconsole. |
09eba48
to
856f9a7
Compare
856f9a7
to
c522c3e
Compare
Migrate to OSGi DS/Metatype annotations. Cleanup of Javadoc. This closes #3262
c522c3e
to
9683835
Compare
…es (Adobe-Consulting-Services#3266) Migrate to OSGi DS/Metatype annotations. Cleanup of Javadoc. This closes Adobe-Consulting-Services#3262 Co-authored-by: david g <davidjgonzalez@users.noreply.github.com>
This allows them to be no longer singletons.
Migrate to OSGi DS/Metatype annotations.
Cleanup of Javadoc.
This closes #3262