Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Manager report fix WrongLogLevelInCatchBlock issue #3301

Conversation

MikhailNavitski
Copy link
Contributor

Fix for the following bugs/code smells from the CM report:
#2931

CQRules:CQBP-44---WrongLogLevelInCatchBlock

@MikhailNavitski MikhailNavitski force-pushed the bugfix/2931/wrong-level-in-catch-block branch from 6d35e29 to ab6e1cb Compare March 23, 2024 21:55
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 55.41%. Comparing base (e6b0676) to head (e055273).

Files Patch % Lines
...mons/adobeio/service/impl/EndpointServiceImpl.java 0.00% 3 Missing ⚠️
...ns/errorpagehandler/impl/ErrorPageHandlerImpl.java 0.00% 2 Missing ⚠️
.../invalidator/HttpCacheInvalidationJobConsumer.java 0.00% 2 Missing ⚠️
...s/adobeio/service/impl/IntegrationServiceImpl.java 0.00% 1 Missing ⚠️
...s/commons/mcp/impl/DialogResourceProviderImpl.java 0.00% 1 Missing ⚠️
...adobe/acs/commons/reports/models/ReportRunner.java 0.00% 1 Missing ⚠️
...er/impl/VersionedClientlibsTransformerFactory.java 0.00% 1 Missing ⚠️
.../twitter/impl/TwitterAdapterFactoryRegisterer.java 0.00% 1 Missing ⚠️
...mons/wcm/comparisons/impl/PageCompareDataImpl.java 0.00% 1 Missing ⚠️
...cs/commons/wcm/impl/ComponentErrorHandlerImpl.java 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3301   +/-   ##
=========================================
  Coverage     55.41%   55.41%           
  Complexity     5515     5515           
=========================================
  Files           721      721           
  Lines         29576    29575    -1     
  Branches       3848     3848           
=========================================
  Hits          16389    16389           
+ Misses        11655    11654    -1     
  Partials       1532     1532           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MikhailNavitski MikhailNavitski force-pushed the bugfix/2931/wrong-level-in-catch-block branch 2 times, most recently from c4d6647 to 2140a65 Compare April 1, 2024 18:39
@MikhailNavitski MikhailNavitski force-pushed the bugfix/2931/wrong-level-in-catch-block branch from 2140a65 to e055273 Compare April 2, 2024 13:34
@davidjgonzalez davidjgonzalez merged commit c004a3f into Adobe-Consulting-Services:master Apr 2, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants