Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code optimization: convert fields to local variables where it's possible #3302

Conversation

MikhailNavitski
Copy link
Contributor

Code optimization: convert class fields to local variables where it's possible

2854

@MikhailNavitski MikhailNavitski force-pushed the defects/2854/code-optimization branch 2 times, most recently from ca4cacf to e538e50 Compare March 25, 2024 20:35
@MikhailNavitski
Copy link
Contributor Author

I guess, The build issue relates to #3287
@kwin @davidjgonzalez

@kwin
Copy link
Contributor

kwin commented Mar 26, 2024

@MikhailNavitski Seems more like a temporary glitch because the GHA is already leveraging the NVD API Token, I just re-executed the action again. Let's see if that fixes it...

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 55.41%. Comparing base (f2ddea8) to head (00da65a).

Files Patch % Lines
...ns/errorpagehandler/impl/ErrorPageHandlerImpl.java 0.00% 2 Missing ⚠️
...cs/commons/version/impl/EvolutionAnalyserImpl.java 0.00% 2 Missing ⚠️
...acs/commons/version/impl/EvolutionContextImpl.java 77.77% 1 Missing and 1 partial ⚠️
...acs/commons/version/impl/CurrentEvolutionImpl.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3302      +/-   ##
============================================
- Coverage     55.43%   55.41%   -0.03%     
  Complexity     5515     5515              
============================================
  Files           721      721              
  Lines         29588    29576      -12     
  Branches       3848     3848              
============================================
- Hits          16402    16389      -13     
- Misses        11654    11655       +1     
  Partials       1532     1532              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidjgonzalez davidjgonzalez added this to the 6.5.2 milestone Mar 26, 2024
@davidjgonzalez davidjgonzalez merged commit e6b0676 into Adobe-Consulting-Services:master Mar 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants