DTM-13100 Report rule completion when rule.actions is undefined. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dompuiu
approved these changes
Apr 16, 2019
|
Should we add a test for this? |
|
Yes. I've added tests. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a Launch library container has a rule that does not have an actions property defined and the rule executes, two things fail to happen:
There is no log message emitted to the console saying that the rule completed.
Launch monitoring hooks don't notify monitors that the rule completed.
This particularly affects users of the Sandbox when they're developing an event type. If they use the library sandbox editor to create a rule that uses their event type, but they don't add an action to the rule (currently there's no built-in action type provided by the sandbox that they could use), there's no way of knowing if their event type is actually running rules like they would expect, because no log message ever shows up saying the rule was run.