Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openEditorPanel to the addOnUISdk reference #79

Merged
merged 3 commits into from
May 29, 2024

Conversation

undavide
Copy link
Collaborator

Description

Add the relevant changes to the Constants and addOnUISdk refs to support addOnUISdk.app.ui.openEditorPanel().

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@hollyschinsky hollyschinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@undavide could you also please just add these changes to the changelog so devs can be aware? Thx!!

@undavide
Copy link
Collaborator Author

@undavide could you also please just add these changes to the changelog so devs can be aware? Thx!!

Jeez, I've forgotten once more!! I will add it immediately. Sorry! 😅

Copy link
Collaborator

@hollyschinsky hollyschinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hollyschinsky hollyschinsky merged commit a4300e7 into main May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants