-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update appendsupplementaldataidto.md #40
base: main
Are you sure you want to change the base?
Conversation
Added logic to show how to obtain the current supplemental data id (SDID)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @sarahelizabethowen I copied your updates over to the internal repo and published through there. Pls see live doc here: https://experienceleague.adobe.com/docs/id-service/using/id-service-api/methods/appendsupplementaldataidto.html Pls feel free to close this PR. Thanks! |
Hi Carlo :)
The changes I provided are not reflected on this page -
https://experienceleague.adobe.com/docs/id-service/using/id-service-api/methods/appendsupplementaldataidto.html
'
This is what I am seeing (please see screenshot below). My changes are not
there.
[image: image.png]
Thanks -
Sarah
…On Wed, Feb 8, 2023 at 2:08 PM Carlo Javier ***@***.***> wrote:
Hi @sarahelizabethowen <https://github.com/sarahelizabethowen> I copied
your updates over to the internal repo and published through there. Pls see
live doc here:
https://experienceleague.adobe.com/docs/id-service/using/id-service-api/methods/appendsupplementaldataidto.html
Pls feel free to close this PR. Thanks!
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2IW7GUDMPDAWAK4ZGVBU3DWWP4MXANCNFSM6AAAAAAUTL5G6E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @sarahelizabethowen, pls try again on incognito or clear cookies in your browser. The changes should be there. Pls see screenshot attached: |
Hi Carlo -
It is getting closer - the 2nd code example is missing the line of code
obtaining the SDID (please see blue and pink arrows below).
Thanks -
Sarah
[image: image.png]
…On Thu, Feb 9, 2023 at 12:30 PM Carlo Javier ***@***.***> wrote:
Hi Sarah, pls try again on incognito or clear cookies in your browser. The
changes should be there. Pls see screenshot attached:
[image: Screen Shot 2023-02-09 at 10 29 16 AM]
<https://user-images.githubusercontent.com/47158132/217904988-1a50b777-08d3-4dee-bff2-bcfc25e81653.png>
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2IW7GTFPAI24S54MT7DB2DWWUZULANCNFSM6AAAAAAUTL5G6E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It is marvelous! Thank you so much, Carlo :)
…On Thu, Feb 9, 2023 at 5:04 PM Carlo Javier ***@***.***> wrote:
Hi Sarah, gotcha, made the update. screenshot attached also:
[image: Screen Shot 2023-02-09 at 3 03 55 PM]
<https://user-images.githubusercontent.com/47158132/217958782-a79a6340-c351-4e3e-85f5-e254867266ac.png>
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2IW7GQP7NOEOSEFZAUIH4LWWVZZLANCNFSM6AAAAAAUTL5G6E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi Javier :)
Hope your week is going great!
Got another update for you :) On this page -
https://experienceleague.adobe.com/docs/id-service/using/id-service-api/methods/appendvisitorid.html
- would you mind adding the following sentence:
In order for the values passed in the URL via appendVisitorsIDsTo to be
picked up, the ovewriteCrossDomain MDCIDAndAID variable
<https://experienceleague.adobe.com/docs/id-service/using/id-service-api/configurations/overwrite-visitor-id.html?>
must be set to true.
Thanks so much -
Sarah :)
…On Wed, Feb 8, 2023 at 2:08 PM Carlo Javier ***@***.***> wrote:
Hi @sarahelizabethowen <https://github.com/sarahelizabethowen> I copied
your updates over to the internal repo and published through there. Pls see
live doc here:
https://experienceleague.adobe.com/docs/id-service/using/id-service-api/methods/appendsupplementaldataidto.html
Pls feel free to close this PR. Thanks!
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2IW7GUDMPDAWAK4ZGVBU3DWWP4MXANCNFSM6AAAAAAUTL5G6E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Ahhhhhh!!! That is AWESOME!! Thank you so much :)
…On Thu, Feb 16, 2023 at 8:31 PM Carlo Javier ***@***.***> wrote:
Hi Sarah!
I've prepped the update on the page. I added the additional text in an
important tag. The preview screenshot is attached. Pls let me know if it's
good to go and I will merge it.
[image: Screen Shot 2023-02-16 at 6 29 03 PM]
<https://user-images.githubusercontent.com/47158132/219534517-3e5967a6-873d-4cd8-8499-695580c2942b.png>
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2IW7GSN36RDDJKXA5Y25PDWX3PG5ANCNFSM6AAAAAAUTL5G6E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @sarahelizabethowen link for the live doc is here: https://experienceleague.adobe.com/docs/id-service/using/id-service-api/methods/appendvisitorid.html Let me know if you need any other updates. Thanks and have a nice weekend! |
THANK YOU so much for adding this as an "important" callout! :)
I did just see that I had a typo -- I accidentally put an extra "D" in
overwriteCrossDomainMCIDAndAID (please see the "D" that the purple arrow is
pointing to below). I am sorry about that.
Have a wonderful weekend -
Sarah :)
[image: image.png]
…On Fri, Feb 17, 2023 at 12:25 PM Carlo Javier ***@***.***> wrote:
Hi @sarahelizabethowen <https://github.com/sarahelizabethowen> link for
the live doc is here:
https://experienceleague.adobe.com/docs/id-service/using/id-service-api/methods/appendvisitorid.html
Let me know if you need any other updates. Thanks and have a nice weekend!
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2IW7GTV6YMJ53ESERKV4RLWX67CPANCNFSM6AAAAAAUTL5G6E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Added logic to show how to obtain the current supplemental data id (SDID)