-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Unsplash plugin sample #52
feat: Added Unsplash plugin sample #52
Conversation
Co-authored-by: Pablo Klaschka <pklaschka@users.noreply.github.com>
Co-authored-by: Pablo Klaschka <pklaschka@users.noreply.github.com>
Co-authored-by: Pablo Klaschka <pklaschka@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review: overall
- 🟢 Overall plugin structure looks awesome!
Review: server
Following README.md
instructions:
- 🟢
npm install
ran successfully - 🟢 Copying
.env.sample
to.env
- 🔴 Change Request:
.env.sample
still contains wrongly namedACCESS_KEY
, should beUNSPLASH_ACCESS_KEY
- 🟡 Minor Change Request:
PORT
should have a default value (both in theREADME.md
and.env.sample
. I.e.,PORT=8000
- 🟢 Run
npm start
=> server appears to be running successfully
Review plugin
Following README.md
instructions:
- 🟢 Run
npm install
=> success - 🟢 Copy
.env.sample
to.env
- 🔴 Change Request: Document what the
API_BASE_URL
should be. I assumehttp://localhost:8000
for the remaining review (as this is where the NodeJS server is running) - 🟡 Minor Change Request: Include a default value for this in both
.env.sample
andREADME.md
, i.e.,API_BASE_URL=http://localhost:8000
- 🟢 Run
npm run build
=> success - 🟢 Use UDT to load the plugin in Photoshop
Functional plugin test
The plugin runs without problems, functionality works as specified. This was what I came up with 😉 :
Conclusion
Overall, this looks great! Two small change requests, but after those are done, we can merge this 🎉 . Thanks again!
@pklaschka Done! Made these changes 🚀 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution 🎉 🙂
(leaving this open for another 24 hours in case @amandahuarng or @kerrishotts want to take a look and I'll merge it afterwards)
This PR closes issue #46.
What does it do?
This is a plugin sample for Photoshop which lets you search for Unsplash images and display the top 10 results in a grid form inside the plugin window. Then you can click on the download button and save those images to your system.
How to run the project?
Please refer to the README in the project for more information.
Sample Preview
Check out the sample preview here