Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added ignoreFiles option to CLI #40

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

alexandrtovmach
Copy link
Contributor

Description

Adding an option to pass extra list of .*ignore files to install command, to get more flexibility to end user:

xdpm install --ignore-files ".gitignore, .xdignore, .npmignore"

More details in related issue #38

Related Issue

#38

Motivation and Context

Described in related issue #38

How Has This Been Tested?

Manually on Windows, but I believe there is no cross-platform issues.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

commands/install.js Outdated Show resolved Hide resolved
Copy link
Contributor

@pklaschka pklaschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... @ashryanbeats @kerrishotts Wanna take a look at it?

@alexandrtovmach
Copy link
Contributor Author

@ashryanbeats @kerrishotts Friendly reminder

@alexandrtovmach
Copy link
Contributor Author

ping-ping

@alexandrtovmach
Copy link
Contributor Author

🙃

@ashryanbeats ashryanbeats merged commit 7138a0d into AdobeXD:master Jul 17, 2020
@alexandrtovmach alexandrtovmach deleted the feat/ignore-files-opt branch July 17, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants