Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kwarg for fixed bin width, ploidy, bin size, number of reads in bin #20

Merged
merged 17 commits into from
Apr 30, 2024

Conversation

Adoni5
Copy link
Owner

@Adoni5 Adoni5 commented Mar 11, 2024

Adds undocumentd kwargs for fixed bin width
needs tests

Update tests
Bump version t0 beta.1
Copy link
Owner Author

@Adoni5 Adoni5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs Documentation updating before merge

@Adoni5 Adoni5 mentioned this pull request Apr 30, 2024
@mattloose
Copy link

I can confirm this fixes the issue raised in #21.

However, it introduces two legacy print statements for every iteration (which is annoying).

@Adoni5 Adoni5 merged commit 4d967ff into main Apr 30, 2024
8 checks passed
@Adoni5 Adoni5 deleted the feature/fixed_bin)width branch April 30, 2024 14:42
@Adoni5 Adoni5 mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants