Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote AdoptOpenJDK Version jdk8u252-b09 #153

Closed
2 tasks done
smlambert opened this issue Apr 16, 2020 · 27 comments
Closed
2 tasks done

Promote AdoptOpenJDK Version jdk8u252-b09 #153

smlambert opened this issue Apr 16, 2020 · 27 comments

Comments

@smlambert
Copy link

smlambert commented Apr 16, 2020

Java Version:
jdk8u252-b09

JVM:

  • OpenJ9
  • Hotspot

@AdoptOpenJDK/tsc please can somebody +1 this request?

@smlambert
Copy link
Author

OpenJ9:
TRSS links: AIX and other platforms

Test_openjdk8_j9_sanity.external_x86-64_linux #266: 3 failures - these are non-blocking, they should get fixed, some are failures related to recent changes to external test targets

@andrew-m-leonard
Copy link

andrew-m-leonard commented Apr 16, 2020

OpenJ9:
jdk8:

checking for protoc... no
configure: error: jitserver requires protoc
configure exiting with result code 1
  • xLinux : Test_openjdk8_j9_sanity.external_x86-64_linux #266: 3 failures - these are non-blocking, they should get fixed, some are failures related to recent changes to external test targets

@gdams
Copy link
Member

gdams commented Apr 16, 2020

@gdams
Copy link
Member

gdams commented Apr 16, 2020

Hotspot JDK8u Failures:

Test_openjdk8_hs_extended.system_x86-64_mac
HCRLateAttachWorkload_0 => long term failure deep history

Test_openjdk8_hs_sanity.openjdk_s390x_linux
jdk_jdi_0 => long term failure deep history - test issue for further triage (did this occur in last release?)
jdk_lang_0 => intermittent failure deep history
jdk_util_0 => intermittent failure deep history

Test_openjdk8_hs_sanity.external_x86-64_linux_tomee
tomee_test_0 => long term failure deep history Non-Blocking #153 (comment) - (still considered non-blocking, but created test issue for triage/fixing)

Test_openjdk8_hs_sanity.system_x86-64_linux
TestJlmRemoteMemoryAuth_SE80_Linux_0 => passed in grinder

Test_openjdk8_hs_sanity.external_x86-64_linux_openliberty-mp-tck
openliberty_microprofile_tck_0 => long term failure deep history Non-Blocking #153 (comment)

Test_openjdk8_hs_sanity.openjdk_x86-32_windows
jdk_jdi_0 => long term failure deep history

Test_openjdk8_hs_sanity.openjdk_x86-64_mac
jdk_jdi_0 => long term failure deep history

Test_openjdk8_hs_sanity.external_x86-64_linux_thorntail-mp-tck
thorntail_microprofile_tck_0 => long term failure deep history Non-Blocking #153 (comment)

Test_openjdk8_hs_sanity.openjdk_x86-64_windows
jdk_jdi_0 => long term failure deep history

@lumpfish
Copy link

Regarding failure

pLinuxXL build failure: machine build-osuosl-centos74-ppc64le-1

checking for protoc... no
configure: error: jitserver requires protoc
configure exiting with result code 1

It looks like pLinux openj9 built successfully on that machine on 10th April: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-linux-ppc64le-openj9/558/

@andrew-m-leonard
Copy link

pLinux when it worked:

checking for jitserver... yes (explicitly enabled)
checking checking that '/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-ppc64le-openj9/workspace/./build//freemarker-2.3.30/freemarker.jar' exists... yes
checking for sysroot... 

when it failed:

checking for jitserver... yes (explicitly enabled)
checking for protoc... no
configure: error: jitserver requires protoc

Seems the check for protoc has been added?

@karianna karianna added this to TODO in openjdk-tsc via automation Apr 16, 2020
@karianna karianna added this to the April 2020 milestone Apr 16, 2020
@karianna karianna moved this from TODO to In Progress in openjdk-tsc Apr 16, 2020
@lumpfish
Copy link

openj9 release builds resubmitted following fix for the ppcle build issue (ibmruntimes/openj9-openjdk-jdk8#403)

New pipeline: https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/990

@lumpfish
Copy link

TRSS link to openj9 respin pipeline: https://trss.adoptopenjdk.net/resultSummary?parentId=5e9855cd0833d14bd533b9d2

@andrew-m-leonard
Copy link

andrew-m-leonard commented Apr 17, 2020

OpenJ9:

14:49:26  	/home/jenkins/workspace/Test_openjdk8_j9_sanity.external_x86-64_linux_openliberty-mp-tck/openjdk-tests/TKG/../external/external.sh --clean --tag ubuntu --version 8 --impl openj9 --dir openliberty-mp-tck; } 2>&1 | tee -a "/home/jenkins/workspace/Test_openjdk8_j9_sanity.external_x86-64_linux_openliberty-mp-tck/openjdk-tests/TKG/../TKG/test_output_15870449669653/TestTargetResult";
14:49:26  No EXTRA_DOCKER_ARGS set
14:49:26  docker: Error response from daemon: Conflict. The container name "/openliberty-mp-tck-test" is already in use by container "81e7baff80acd9dae4af7f7c69e7443b452fbf63076800b0fd4d7415dc07437d". You have to remove (or rename) that container to be able to reuse that name.

@andrew-m-leonard
Copy link

@AdoptOpenJDK/tsc request to publish OpenJ9 jdk8u252-b09 please?

@karianna
Copy link
Member

+1

@smlambert
Copy link
Author

+1 to publishing both openj9 and hotspot

Speaking to @gdams - we will plan to release hotspot also. Note on QA: I am working through the list of test failures and creating independent issues for each of the remaining failures so they can be properly triaged. For the release retrospective, I recommend this activity happen more regularly or at minimum the week before release so that we enter the release with a clean slate.

@gdams
Copy link
Member

gdams commented Apr 17, 2020

jdk8u252-b09 hotspot released on all platforms except for aarch64

@gdams
Copy link
Member

gdams commented Apr 17, 2020

jdk8u252-09 aarch64 https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/993/

No Test Failures! 🎉

https://trss.adoptopenjdk.net/buildDetail?parentId=5e99b7674b7a9f456900fd75&testSummaryResult=passed&buildNameRegex=%5ETest.*

@tsc request to publish

@sxa
Copy link
Member

sxa commented Apr 17, 2020

+1 to aarch64/HotSpot

@gdams
Copy link
Member

gdams commented Apr 22, 2020

Notarized jdk8u252-b09 build is complete: https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/1001/

Test Failures:

Test_openjdk8_hs_extended.system_x86-64_mac
HCRLateAttachWorkload_0 => long term failure deep history - Failed in previous release as well

Test_openjdk8_hs_sanity.system_x86-64_mac
TestJlmRemoteMemoryAuth_SE80_0 => passed on re-run grinder

@gdams
Copy link
Member

gdams commented Apr 22, 2020

@tsc request to publish Notarized JDK8u build

@karianna
Copy link
Member

+1

@lumpfish
Copy link

lumpfish commented Apr 23, 2020

Windows and Mac openj9 releases have been rebuilt to:

  1. Upgrade the bundled OpenSSL to the latest level (1.1.1g)
  2. Include the fix for jdk-11.0.7+10.1 for Windows binary is not signed by digital certification. adoptium/temurin-build#1694 (Windows binaries signing)
  3. Add Mac notarization support.

Build pipeline: https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/1003/
TRSS: https://trss.adoptopenjdk.net/resultSummary?parentId=5ea054e04b7a9f45690d6150 (no failures)

Windows X64 build has been downloaded from the job and checked for 'Digital Signatures' tab in Properties.

@gdams
Copy link
Member

gdams commented Apr 23, 2020

hotspot win rebuild:

https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/1002/
TRSS: https://trss.adoptopenjdk.net/buildDetail?parentId=5ea011374b7a9f45690d4d29

Failures:

Test_openjdk8_hs_sanity.openjdk_x86-64_windows
jdk_util_0 => passed in grinder
jdk_jdi_0 => long term failure deep history

Test_openjdk8_hs_sanity.openjdk_x86-32_windows
jdk_jdi_0 => long term failure deep history

@lumpfish
Copy link

@tsc - request to publish the openj9 release rebuilds as jdk8u252-b09.1_openj9-0.20.0.

@gdams
Copy link
Member

gdams commented Apr 23, 2020

@lumpfish +1 (note that @tsc is a user not @AdoptOpenJDK/tsc I noticed I was doing the same thing earlier

@lumpfish
Copy link

You mean I should use tag @AdoptOpenJDK/tsc to alert tsc members?

@gdams
Copy link
Member

gdams commented Apr 23, 2020

correct 👍

@gdams
Copy link
Member

gdams commented Apr 23, 2020

@AdoptOpenJDK/tsc request to publish hotspot win rebuild

@sxa
Copy link
Member

sxa commented Apr 23, 2020

Approved - go for it

@lumpfish
Copy link

openjdk-tsc automation moved this from In Progress to Done Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
openjdk-tsc
  
Done
Development

No branches or pull requests

6 participants