Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch + PATH + slim-build.sh fixes #33

Merged

Conversation

dinogun
Copy link
Collaborator

@dinogun dinogun commented Jun 28, 2018

  1. Fix aarch docker image (pick latest tarball for multiple builds).
  2. Fix PATH for all builds.
  3. Update the slim-build.sh to the correct one !

1. Fix aarch docker image (pick latest tarball for multiple builds).
2. Fix PATH for all builds.
3. Update the slim-build.sh to the correct one !
@dinogun
Copy link
Collaborator Author

dinogun commented Jun 28, 2018

Looks like I checked-in the wrong version of slim-build.sh in the previous PR. This PR updates that to the right file and a few other minor updates. Am testing this on all platforms. Will remove WIP once they go through fine.

@dinogun dinogun changed the title WIP: Bunch of minor fixes. WIP: aarch + PATH + slim-build.sh fixes Jun 28, 2018
fi

# Validate prerequisites(tools) necessary for making a slim build
tools="jar jarsigner pack200 strip"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI in case you missed it...
http://openjdk.java.net/jeps/336

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be run for Java 8 binaries

@tellison
Copy link
Member

This looks good. I wonder if the stripping logic should more naturally form part of the build script logic than the Docker preparation? I can imagine that we'd be interested in this for a wide variety of distribution formats. Over time perhaps we'd consider moving it over there.

@karianna karianna added this to To do in openjdk-docker via automation Jun 28, 2018
@karianna karianna added the bug label Jun 28, 2018
@karianna
Copy link
Member

@tellison We actually discussed that in the build meeting and @dinogun has a plan for that yes.

@karianna karianna moved this from To do to QA / Review in openjdk-docker Jun 28, 2018
@dinogun
Copy link
Collaborator Author

dinogun commented Jun 29, 2018

@tellison That is the plan. Please also look at the original slim build PR #29 where I've said the same thing. In addition to getting this as part of the build scripts, we also need to get the headless TCK testing in place as well.

@dinogun dinogun changed the title WIP: aarch + PATH + slim-build.sh fixes aarch + PATH + slim-build.sh fixes Jun 29, 2018
@dinogun
Copy link
Collaborator Author

dinogun commented Jun 29, 2018

Removing WIP as I've tested this. However I did see an issue with nightly sum mismatch in x64 builds in 1 out of 5 tests. That looks like a separate problem (with how the "latest" tag is associated). Will open a separate issue for that at the build repo. Please review, thanks

@dinogun
Copy link
Collaborator Author

dinogun commented Jul 3, 2018

@tellison @karianna Please review. My test builds with the above changes are going through fine.

Copy link
Member

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit dc6eed2 into AdoptOpenJDK:master Jul 4, 2018
openjdk-docker automation moved this from QA / Review to Done Jul 4, 2018
@dinogun dinogun deleted the fix_aarch_builds_minor_updates branch July 19, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants