Windows builds broken

[M-Davies]

Platform:
All Windows builds and versions
Architecture:
All archs and variants

Windows builds are completely broken this morning across the nightlies. Exhibit A: https://ci.adoptopenjdk.net/view/Test_openjdk/job/Test_openjdk8_j9_sanity.openjdk_x86-64_windows/211/console

Started by upstream project "build-scripts/jobs/jdk8u/jdk8u-windows-x64-openj9" build number 705
originally caused by:
 Started by upstream project "build-scripts/openjdk8-pipeline" build number 1089
 originally caused by:
  Started by timer
Obtained buildenv/jenkins/openjdk_tests from git https://github.com/AdoptOpenJDK/openjdk-tests.git
Running in Durability level: PERFORMANCE_OPTIMIZED
[Pipeline] Start of Pipeline
[Pipeline] echo
SPEC: win_x86-64_cmprssptrs
[Pipeline] echo
LABEL: ci.role.test&&hw.arch.x86&&sw.os.windows
[Pipeline] stage
[Pipeline] { (Queue)
[Pipeline] node
Running on test-aws-win2019-x64-2 in C:\Users\jenkins.EC2AMAZ-T7I06S9\workspace\Test_openjdk8_j9_sanity.openjdk_x86-64_windows
[Pipeline] {
[Pipeline] }
[Pipeline] // node
[Pipeline] }
[Pipeline] // stage
[Pipeline] End of Pipeline
hudson.remoting.ProxyException: groovy.lang.MissingPropertyException: No such property: HOME for class: WorkflowScript
	at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:53)
	at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.getProperty(ScriptBytecodeAdapter.java:458)
	at org.kohsuke.groovy.sandbox.impl.Checker$7.call(Checker.java:355)
	at org.kohsuke.groovy.sandbox.GroovyInterceptor.onGetProperty(GroovyInterceptor.java:68)
	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onGetProperty(SandboxInterceptor.java:354)
	at org.kohsuke.groovy.sandbox.impl.Checker$7.call(Checker.java:353)
	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:357)
	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:333)
	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:333)
	at com.cloudbees.groovy.cps.sandbox.SandboxInvoker.getProperty(SandboxInvoker.java:29)
	at com.cloudbees.groovy.cps.impl.PropertyAccessBlock.rawGet(PropertyAccessBlock.java:20)
	at WorkflowScript.run(WorkflowScript:144)
	at ___cps.transform___(Native Method)
	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.get(PropertyishBlock.java:74)
	at com.cloudbees.groovy.cps.LValueBlock$GetAdapter.receive(LValueBlock.java:30)
	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.fixName(PropertyishBlock.java:66)
	at sun.reflect.GeneratedMethodAccessor186.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)
	at com.cloudbees.groovy.cps.impl.ConstantBlock.eval(ConstantBlock.java:21)
	at com.cloudbees.groovy.cps.Next.step(Next.java:83)
	at com.cloudbees.groovy.cps.Continuable$1.call(Continuable.java:174)
	at com.cloudbees.groovy.cps.Continuable$1.call(Continuable.java:163)
	at org.codehaus.groovy.runtime.GroovyCategorySupport$ThreadCategoryInfo.use(GroovyCategorySupport.java:129)
	at org.codehaus.groovy.runtime.GroovyCategorySupport.use(GroovyCategorySupport.java:268)
	at com.cloudbees.groovy.cps.Continuable.run0(Continuable.java:163)
	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.access$001(SandboxContinuable.java:18)
	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.run0(SandboxContinuable.java:51)
	at org.jenkinsci.plugins.workflow.cps.CpsThread.runNextChunk(CpsThread.java:185)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:400)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$400(CpsThreadGroup.java:96)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:312)
	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:276)
	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:67)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Finished: FAILURE

[M-Davies]

Builds on 27th may were ok. The 28th was when we first started seeing these failures

[M-Davies]

It was caused by #1794. I was looking in the wrong repo 😅

[sxa]

ping @AdamBrousseau

[M-Davies]

Looks like HOME doesn't exist on Windows https://superuser.com/questions/607105/is-the-home-environment-variable-normally-set-in-windows. We would have to add in an alternative variable for windows tests. I'll see if I can make a draft PR before Canada wakes up

[sxa]

From memory I think it's HOMEPATH or something like that on Windows

[smlambert]

#1794

Do test jobs also fail at the openj9 and internal servers? or have those machines been configured differently?

[smlambert]

I think this is due to a pending script approval at the Jenkins server, which I will check for.

Edit: no pending approvals, someone else must have approved the testJobTemplate change (from #1794) already.

[smlambert]

From a test job at openj9 project:

[M-Davies]

@sxa Do we set the HOME variable in our playbooks (or at any point prior to kick_off_build)?

[M-Davies]

I can see that we set HOME for windows playbook testing https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/8b955671b060eef7770febec312172b270ecc48c/ansible/pbTestScripts/testJDKWin.sh#L5

[sxa]

@M-Davies It's standard on all UNIX systems (I would expect this to include cygwin) so no it's not something we set

(Not sure what you were referencing in that link - that line is moving something into $HOME, not setting it to anything)

[M-Davies]

Odd that it's not picking it up. HOME is set on the last passing test scripts e.g. https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_sanity.openjdk_x86-64_windows_xl/223/console

15:13:45  HOME=/home/jenkins