Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference repo path for initial scm checkout #1794

Merged
merged 1 commit into from
May 27, 2020

Conversation

AdamBrousseau
Copy link
Contributor

It is currently set in the job config and propagated down
to the build during checkout scm. The problem is the
'$HOME' variable is not getting resolved so the clone
is looking for exactly that. Moving it out of the
job config (template) and into the pipeline will allow
it to be resolved properly. It is also not needed on the
job config because we use a lightweight checkout.

Fixes #1789

Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com

It is currently set in the job config and propagated down
to the build during checkout scm. The problem is the
'$HOME' variable is not getting resolved so the clone
is looking for exactly that. Moving it out of the
job config (template) and into the pipeline will allow
it to be resolved properly. It is also not needed on the
job config because we use a lightweight checkout.

Fixes adoptium#1789

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau
Copy link
Contributor Author

Note this will require admin script approvals on all the servers.
Internal test build
job/adam_Test_openjdk11_j9_sanity.functional_x86-64_linux_Personal/9/console

@karianna karianna added the bug label May 24, 2020
@karianna karianna added this to the May 2020 milestone May 24, 2020
@smlambert
Copy link
Contributor

a couple other template changes in plan for this week, plan to coordinate merge of this with the others

@llxia
Copy link
Contributor

llxia commented May 27, 2020

Since we have the template file whitelisted, I am going to merge this change.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=563563

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit e5266c1 into adoptium:master May 27, 2020
@llxia
Copy link
Contributor

llxia commented May 27, 2020

Test_Job_Auto_Gen completed successfully.
https://ci.eclipse.org/openj9/view/Test/job/Test_Job_Auto_Gen/28926/console

@smlambert smlambert mentioned this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone reference repo path is looking for '$HOME'
4 participants