Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathLoadTest_all_0 FAILED in Test_openjdk14_hs_extended.system_aarch64_linux #1893

Closed
d3r3kk opened this issue Jul 15, 2020 · 5 comments
Closed
Assignees
Labels
triage required Issue needs deeper triage to determine which repo to move issue into
Projects
Milestone

Comments

@d3r3kk
Copy link
Contributor

d3r3kk commented Jul 15, 2020

Test Info
Test Name: MathLoadTest_all_0
Test Duration: 11 sec
Machine: test-aws-ubuntu1804-armv8-1
TRSS link for the test output: https://trss.adoptopenjdk.net/output/test?id=5f0edf557eaab3443ca848c4

Build Info
Build Name: Test_openjdk14_hs_extended.system_aarch64_linux
Jenkins Build start time: Jul 15 2020, 02:39 am
Jenkins Build URL: https://ci.adoptopenjdk.net/job/Test_openjdk14_hs_extended.system_aarch64_linux/140/
TRSS link for the build: https://trss.adoptopenjdk.net/allTestsInfo?buildId=5f0eded87eaab3443ca8477b

Java Version
[0.009s][error][cds] Unable to map CDS archive -- os::vm_allocation_granularity() expected: 65536 actual: 4096
openjdk version "14.0.2" 2020-07-14
OpenJDK Runtime Environment AdoptOpenJDK (build 14.0.2+12)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 14.0.2+12, mixed mode)

This test has been failed 19 times since Jun 25 2020, 01:45 pm
Java Version when the issue first seen
openjdk version "14.0.1" 2020-04-14
OpenJDK Runtime Environment AdoptOpenJDK (build 14.0.1+7-202006252018)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 14.0.1+7-202006252018, mixed mode, sharing)
Jenkins Build URL: https://ci.adoptopenjdk.net/job/Test_openjdk14_hs_extended.system_aarch64_linux/122/

The test failed on machine test-aws-ubuntu1804-armv8-1 1 times
The test failed on machine test-aws-rhel76-armv8-3 3 times
The test failed on machine test-aws-rhel76-armv8-4 3 times
The test failed on machine test-packet-ubuntu1604-armv8-1 4 times
The test failed on machine test-aws-rhel76-armv8-2 2 times
The test failed on machine test-packet-ubuntu1604-armv8-2 2 times
The test failed on machine test-aws-rhel76-armv8-6 2 times
The test failed on machine test-aws-rhel76-armv8-1 1 times
The test failed on machine test-aws-rhel76-armv8-5 1 times

@d3r3kk d3r3kk added this to To do in Top Priorities via automation Jul 15, 2020
@karianna karianna added this to the July 2020 milestone Jul 15, 2020
@karianna karianna removed this from To do in Top Priorities Jul 15, 2020
@karianna karianna added this to TODO in aqa-tests via automation Jul 15, 2020
@karianna karianna added this to To do in Top Priorities via automation Jul 15, 2020
@smlambert smlambert modified the milestones: July 2020, September 2020 Sep 15, 2020
@smlambert smlambert added the triage required Issue needs deeper triage to determine which repo to move issue into label Oct 2, 2020
@smlambert smlambert removed this from the September 2020 milestone Oct 6, 2020
@smlambert
Copy link
Contributor

This failure likely still applies to jdk15. @lumpfish - would you be able to take a look at this test running against hotspot to make sure the test material is valid?

Potentially related (though I have not looked at the test source to confirm): eclipse-openj9/openj9#10918 - hotspot answer to math.pow() are 'not correct' (but the Java spec allows for them to be not correct).

@lumpfish
Copy link
Contributor

Yes, I'll take a look.

@karianna karianna moved this from TODO to In Progress in aqa-tests Oct 21, 2020
@karianna karianna moved this from To do to In progress in Top Priorities Oct 21, 2020
@karianna karianna added this to the October 2020 milestone Oct 21, 2020
@lumpfish
Copy link
Contributor

lumpfish commented Oct 21, 2020

There are similar failures across some of the platforms in both jdk11 and jdk15. The tests are complaining about the precision of various operations being incorrect - -e.g.

jdk15
aarch64
22:19:25  MLT testFailure: testCos(net.adoptopenjdk.test.math.MathAPITest): cos(double)[0] :: expected:<-0.9999876894265599> but was:<-0.99998768942656>
22:19:25  MLT junit.framework.AssertionFailedError: cos(double)[0] :: expected:<-0.9999876894265599> but was:<-0.99998768942656>

jdk11
ppc64_aix
02:22:58  MLT testFailure: testTan(net.adoptopenjdk.test.math.MathAPITest): tan(double)[10] :: expected:<1.2786058599594134> but was:<1.2786058599594137>
02:22:58  MLT junit.framework.AssertionFailedError: tan(double)[10] :: expected:<1.2786058599594134> but was:<1.2786058599594137>

Quoting from the eclipse/openj9 issue eclipse-openj9/openj9#10918:

Actually, it's Hotspot that has the "incorrect" answer, although this is allowed by the spec. Using StrictMath, the answer is 13.966610165238237 on both OpenJ9 and Hotspot.

"Unlike some of the numeric methods of class StrictMath, all implementations of the equivalent functions of class Math are not defined to return the bit-for-bit same results. This relaxation permits better-performing implementations where strict reproducibility is not required."

I haven't found any failures in any of the jdk8 nightly test runs, but I'll do some more pointed testing and see exactly which releases and platforms we do see it on.

So I don't think there's anything wrong with the test case per se, but if the result of an operation cannot be predicted then it's not easy to test it.

@lumpfish
Copy link
Contributor

I've done some analysis and made a proposal for making the test more robust in adoptium/aqa-systemtest#376.

@lumpfish
Copy link
Contributor

This is fixed by adoptium/aqa-systemtest#378

aqa-tests automation moved this from In Progress to Done Nov 30, 2020
Top Priorities automation moved this from In progress to Done Nov 30, 2020
@gdams gdams removed this from Done in Top Priorities Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage required Issue needs deeper triage to determine which repo to move issue into
Projects
No open projects
aqa-tests
  
Done
Development

No branches or pull requests

4 participants