-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest release page does not have clickable github release links #753
Comments
I looked into this, and it seems like the problem could be in data being lost somehow when it's manipulated in JS file. However, the problem I encountered was that any time I made a small change in JS file, like
Since I've never worked with your repo yet, I thought it might be worth asking if there is something you've set up explicitly with JS processing and I have to first "switch" to work with local files and be able to change their values? |
It sounds like you're on the right track, but I think it may be related to how the API endpoints differ between each page. It looks like the Archive page is pulling data from
API response from the Archive page example (Huge JSON warning) Whereas the Latest Releases page is hitting
API response from the Latest Release page example
That issue sounds oddly familiar, I think I ran into something similar before when I was using an incompatible version of node. It looks version 10 is the one currently used in Travis CI, and switching to version 10 with |
Wow, @ParkerM what a great response 👍 Thank you Ok, it looks like it is the case with the API response being different.
I explored this API's structure page but only found a couple of example queries. Maybe there is a better way to query API and get the relevant Do you think there's a way to try and change the API's response and get it done this way? PS. I ended up reinstalling my os and installing node using |
Agreed that those sound like the two most valid options. I'm inclined to say that the first one seems like the most sensible approach. Namely because both of those API endpoints return a Alternatively, the second approach could work by grabbing the version string from the GET [
{
"binary": {},
"version": {
"semver": "11.0.8+10"
}
},
] GET [
{
"binaries": [],
"release_link": "https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/tag/jdk-11.0.8%2B10",
"version_data": {}
}
] It'd be less than ideal to have to make a second request just for the release link, and it'd kind of misappropriate that particular API, but that's one idea. There may be a more lightweight API that could accomplish the same thing. One thing's kinda funky about the GitHub release links as they pertain to this issue, and is likely the reason that That may be counterintuitive from a UX perspective since the Latest Release "panes" are grouped by OS/Arch, implying that a link in one pane would point to something specific to that OS/Arch when really they all point to the same place. I'm probably nitpicking but figured I should bring it up (@sxa may have additional thoughts).
You might have better luck with the Swagger UI. It'll show all the available endpoints and schema definitions for the resources returned by each. |
Closing in favour of adoptium/adoptium.net#117 |
On https://adoptopenjdk.net/archive.html the release names in the squares on the left of the page are clickable and take you to the coirresponding github release, but in the "Latest release" page at https://adoptopenjdk.net/releases.html they are no such links.
The text was updated successfully, but these errors were encountered: