Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title/sentence case bug #127

Merged
merged 2 commits into from
Sep 23, 2018
Merged

Fix title/sentence case bug #127

merged 2 commits into from
Sep 23, 2018

Conversation

Adriandmen
Copy link
Owner

Description

Fixes the ignoring of newlines in the title/sentence case commands. The cause of this is that the regex does not include newlines when using .. This is fixed by adding the dotall-flag (s) to the regex.

Tests have been added as well:

@codecov
Copy link

codecov bot commented Sep 23, 2018

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          17       17           
  Lines        1749     1749           
=======================================
  Hits         1677     1677           
  Misses         72       72
Impacted Files Coverage Δ
lib/commands/str_commands.ex 92.43% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51a5aa...6267d01. Read the comment docs.

@Adriandmen Adriandmen merged commit 45c0e2c into master Sep 23, 2018
@Adriandmen Adriandmen deleted the fix-title-case branch September 23, 2018 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant