Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global predicate on install #26

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

AdrieanKhisbe
Copy link
Owner

As point out in #25 max-overall-size was not working correctly

Fix #25

@AdrieanKhisbe AdrieanKhisbe added the Bug 🐛 Ooops, something is not working as it should label Mar 17, 2020
@AdrieanKhisbe AdrieanKhisbe self-assigned this Mar 17, 2020
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #26 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files           8        8           
  Lines         292      292           
  Branches       61       61           
=======================================
  Hits          287      287           
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/install.js 95.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4078266...5bd33d3. Read the comment docs.

@AdrieanKhisbe AdrieanKhisbe merged commit dd8bf14 into master Mar 17, 2020
@AdrieanKhisbe AdrieanKhisbe deleted the fixing-global-predicate-on-install branch March 17, 2020 23:06
@AdrieanKhisbe
Copy link
Owner Author

Published as bundle-phobia-cli@0.14.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Ooops, something is not working as it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Size of package returns null on install
1 participant