fix: fix hover dropdown menu does not display single menu item #1150
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 88 88
Lines 1297 1307 +10
Branches 322 325 +3
=========================================
+ Hits 1297 1307 +10
Continue to review full report at Codecov.
|
lightbringer1991
force-pushed
the
fix-hover-popover-1-child
branch
3 times, most recently
from
ccb806f
to
dab42db
Compare
lightbringer1991
force-pushed
the
fix-hover-popover-1-child
branch
from
dab42db
to
a20ce90
Compare
| triggers={['disabled']} | ||
| isOpen={isOpen || mouseInPopover} | ||
| title={headerText} | ||
| popoverContent={<ul className="list-unstyled">{children}</ul>} | ||
| popperRef={setPopperNode} | ||
| arrowStyles={arrowPosition === 'none' ? { display: 'none' } : null} |
There was a problem hiding this comment.
maybe add a modifiers props here as well, in case you want to customize it later
There was a problem hiding this comment.
you can either expose popoverModifiers or considering pre-defined modifiers like set the width of the popper as the width of the reference
There was a problem hiding this comment.
sorry, I just found we have a props named popoverProps in the <TextEllipsis /> so maybe pass popoverProps to the <Popover />
Fix Hover Dropdown Menu does not display when there is only 1 menu item.
Description
Does this PR introduce a breaking change?
Manual testing step?
Screenshots (if appropriate):