refactor: convert FilePicker into functional component #1235
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1235 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 93 93
Lines 1377 1361 -16
Branches 344 339 -5
=========================================
- Hits 1377 1361 -16
Continue to review full report at Codecov.
|
chaofan232
force-pushed
the
convert-filepicker
branch
from
7857247
to
ff8f585
Compare
src/components/FilePicker/index.jsx
Outdated
| const FilePicker = ({ filter, dts, placeholder, onSelect, onRemove, isHighlighted, disabled, label }) => { | ||
| const fileInputRef = React.useRef(); | ||
| const [fileName, setFileName] = React.useState(''); | ||
| const [isFileSelected, setIsFileSelected] = React.useState(false); |
There was a problem hiding this comment.
i think this state is redundant. maybe you can have a look see if you can remove it
www/containers/props.json
Outdated
| @@ -957,13 +957,13 @@ | |||
| "methods": [ | |||
| { | |||
| "name": "usePreventSwipeClicks", | |||
| "docblock": "A hook to prevent child click handlers from firing immediately after swiping the Carousel\n\n@returns {object} - handlers to be spread onto any carousel items with `onClick` handlers", | |||
There was a problem hiding this comment.
why is this change here?
| @@ -11,7 +11,6 @@ | |||
| background-color: $color-disabled; | |||
| border: 0; | |||
| box-shadow: none; | |||
| height: 28px; | |||
There was a problem hiding this comment.
context for the css change?
There was a problem hiding this comment.
the two buttons (X & select) have the different height, so I removed here and added the height into .aui--button selector which can be applied for two buttons for alignment. Should I just leave the style as the same as before?
chaofan232
force-pushed
the
convert-filepicker
branch
from
ff8f585
to
f7107de
Compare
chaofan232
force-pushed
the
convert-filepicker
branch
from
f7107de
to
9fef8ea
Compare
Description
Does this PR introduce a breaking change?
Manual testing step?
Screenshots (if appropriate):