fix: improve debounce implementation #1573
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knilink
force-pushed
the
fix-debounce
branch
3 times, most recently
from
5294ca4
to
83f239d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1573 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 96 97 +1
Lines 1695 1731 +36
Branches 471 476 +5
=========================================
+ Hits 1695 1731 +36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
knilink
force-pushed
the
fix-debounce
branch
10 times, most recently
from
c19f1cf
to
db74289
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
improve debounce implementation
after the update,
Searchwill only debounce entering action. hitting enter or clicking clear will triggeronSearchimmediately.also adding dev dep
@testing-library/react-hooksDoes this PR introduce a breaking change?
Manual testing step?
Screenshots (if appropriate):