Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new DropdownMenu component #1583

Open
wants to merge 1 commit into
base: popover-refactor
Choose a base branch
from

Conversation

renrizzolo
Copy link
Contributor

Adds a new dropdown menu component

Description

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@renrizzolo renrizzolo force-pushed the dropdown-menu-on-popover-changes branch from 9383ddb to dfd65e6 Compare March 23, 2023 01:24
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #1583 (5009022) into popover-refactor (b1e3259) will not change coverage.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           popover-refactor     #1583    +/-   ##
===================================================
  Coverage            100.00%   100.00%            
===================================================
  Files                   100       101     +1     
  Lines                  1920      2105   +185     
  Branches                558       602    +44     
===================================================
+ Hits                   1920      2105   +185     
Impacted Files Coverage Δ
src/components/DismissibleFocusTrap/index.jsx 100.00% <ø> (ø)
src/components/Panel/index.jsx 100.00% <ø> (ø)
src/components/Button/index.jsx 100.00% <100.00%> (ø)
src/components/ButtonGroup/index.jsx 100.00% <100.00%> (ø)
src/components/Checkbox/index.jsx 100.00% <100.00%> (ø)
src/components/CheckboxGroup/index.jsx 100.00% <100.00%> (ø)
src/components/DropdownMenu/index.jsx 100.00% <100.00%> (ø)
src/components/Radio/index.jsx 100.00% <100.00%> (ø)
src/components/RadioGroup/index.jsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@renrizzolo renrizzolo force-pushed the dropdown-menu-on-popover-changes branch from dfd65e6 to 5009022 Compare March 23, 2023 02:29
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant