Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Airtight Seal enchant O2 calculation is wrong #2383

Open
Deiwos opened this issue Jan 8, 2024 · 0 comments
Open

[BUG] Airtight Seal enchant O2 calculation is wrong #2383

Deiwos opened this issue Jan 8, 2024 · 0 comments

Comments

@Deiwos
Copy link

Deiwos commented Jan 8, 2024

Forge version: 14.23.5.2860
AR version: 1.12.2-2.0.0-17
LibVulpes version: 1.12.2-0.4.2-25

The code for determining the Airtight Seal O2 value is:

@Override
public int getMaxAir(@Nonnull ItemStack stack) {
    return ARConfiguration.getCurrentConfig().spaceSuitOxygenTime*1200; //30 minutes;
}

and

arConfig.spaceSuitOxygenTime = config.get(OXYGEN, "spaceSuitO2Buffer", 30, "Maximum time in minutes that the spacesuit's internal buffer can store O2 for").getInt();

However, the 1200 value is based off the idea that o2 drains at 1mb/tick which it most certainly does not. It's more like 1mb/0.5s, which means you need to set spaceSuitO2Buffer to 3 to get 30 minutes of oxygen. 30x1200 is 36000, which is 5 hours of oxygen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant