Support for signed values. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR already includes some code related to #11. |
| .. module:: umodbus.config | ||
|
|
||
| .. autoclass:: Config | ||
| :members: SIGNED_VALUES |
There was a problem hiding this comment.
I think a config member is missing here?
There was a problem hiding this comment.
No, but I understand the confusion. I already included some code for a new feature: 32 bit values. The BIT_SIZE settings is related to this issue, but isn't functional yet. Currently bit size is 16 bit always, ignore this setting. That is the reason for not in including this setting in the docs right now.
|
LGTM 👍 |
hmaerki
pushed a commit
to hmaerki/fork-uModbus-obsolete
that referenced
this pull request
Dec 31, 2023
hmaerki
pushed a commit
to hmaerki/fork-uModbus-obsolete
that referenced
this pull request
Dec 31, 2023
hmaerki
pushed a commit
to hmaerki/fork-uModbus-obsolete
that referenced
this pull request
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.