Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong import in simple_tcp_server example #47

Merged
merged 1 commit into from
Nov 11, 2016
Merged

Fix wrong import in simple_tcp_server example #47

merged 1 commit into from
Nov 11, 2016

Conversation

tiagocoutinho
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 30, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 95.778% when pulling 93b28ce on tiagocoutinho:develop into ebcc6e7 on AdvancedClimateSystems:develop.

@coveralls
Copy link

coveralls commented Oct 30, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 95.778% when pulling 4e02abd on tiagocoutinho:develop into ebcc6e7 on AdvancedClimateSystems:develop.

OrangeTux
OrangeTux reviewed Oct 31, 2016
View reviewed changes
scripts/examples/simple_tcp_server.py
@@ -5,7 +5,7 @@
from collections import defaultdict

from umodbus import conf
from umodbus.server import get_server
from umodbus.server.tcp import get_server
from umodbus.server.tcp import RequestHandler
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports on line 8 and 9 can be joined in a single import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I'll change ASAP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done.
Travis reports code is broken in pypy3 but I don't think it's because of me

Copy link
Collaborator

@OrangeTux OrangeTux Oct 31, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to apply the same fix on the example in the README.md as well. Sorry, I forgot to mention it before.

Travis is not broken because of these commits. Travis builds for PyPy are acting weird. I already created an issue #42 .

@coveralls
Copy link

coveralls commented Oct 31, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 95.778% when pulling a0dcd8f on tiagocoutinho:develop into 789aff4 on AdvancedClimateSystems:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.778% when pulling a0dcd8f on tiagocoutinho:develop into 789aff4 on AdvancedClimateSystems:develop.

OrangeTux
OrangeTux requested changes Oct 31, 2016
View reviewed changes
README.rst
@@ -35,7 +35,7 @@ Creating a Modbus TCP server is easy:
from collections import defaultdict

from umodbus import conf
from umodbus.server import get_server
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports on line 8 and 9 can be joined in a single import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it it should be ok now

@coveralls
Copy link

coveralls commented Nov 11, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 95.778% when pulling 4edde8f on tiagocoutinho:develop into 2309a96 on AdvancedClimateSystems:develop.

@OrangeTux OrangeTux merged commit eb513c3 into AdvancedClimateSystems:develop Nov 11, 2016
@OrangeTux
Copy link
Collaborator

Thanks! Your changes are in release 0.8.2.

hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
add Queue based on uasyncio, relates to AdvancedClimateSystems#47
7409165
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
implement fake for UART and Pin of machine, contributes to AdvancedCl…
c68f4e6 
…imateSystems#47
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
rename docker files to be TCP specific, relates to AdvancedClimateSys…
b54b571 
…tems#47
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
update RTU client example for Docker usage as in TCP client example, …
84fe3bf 
…contributes to AdvancedClimateSystems#47
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
add RTU host example, relates to AdvancedClimateSystems#47
511ddfa
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
add Dockerfiles for RTU, contributes to AdvancedClimateSystems#47
551d681
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
add docker compose file for RTU example run, contributes to AdvancedC…
f58858e 
…limateSystems#47
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
add unittest for RTU example, contributes to AdvancedClimateSystems#47
664ce1b
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
add docker compose file to run RTU unittest, contributes to AdvancedC…
a9ce105 
…limateSystems#47
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
add test_rtu_example to tests init file as comment, contributes to Ad…
479e2ed 
…vancedClimateSystems#47
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
add RTU example and test to test workflow, relates to AdvancedClimate…
8572553 
…Systems#47
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
add RTU example section for Client and Host, relates to AdvancedClima…
18023c0 
…teSystems#47
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
@brainelectronics
update Docker compose usage section for new RTU compose file, relates…
4340d35 
… to AdvancedClimateSystems#47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrangeTux OrangeTux OrangeTux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiagocoutinho @coveralls @OrangeTux