Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8 Fix unpacking of values for WritingMultipleCoils request. #9

Merged
merged 3 commits into from
Nov 16, 2015

Conversation

OrangeTux
Copy link
Collaborator

No description provided.

@OrangeTux OrangeTux assigned OrangeTux and jaapz and unassigned OrangeTux Nov 14, 2015
@@ -665,6 +664,41 @@ def __init__(self, starting_address, quantity, byte_count, values):
def create_from_request_pdu(cls, pdu):
""" Create instance from request PDU.

This method requires some clarification regarding the unpacking of
the statusses that are being passed to the callbacks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statusses

moet zijn

statuses

@jaapz
Copy link
Member

jaapz commented Nov 16, 2015

LGTM 👍

OrangeTux added a commit that referenced this pull request Nov 16, 2015
#8 Fix unpacking of values for WritingMultipleCoils request.
@OrangeTux OrangeTux merged commit aed33d8 into develop Nov 16, 2015
@OrangeTux OrangeTux deleted the #8 branch November 16, 2015 10:46
hmaerki pushed a commit to hmaerki/fork-uModbus-obsolete that referenced this pull request Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants