Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2 error codes #94

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix 2 error codes #94

merged 1 commit into from
Jun 23, 2020

Conversation

OrangeTux
Copy link
Collaborator

The error codes where off by 1.

Fixes: #90

@OrangeTux
Fix 2 error codes
5fdc3b8 
The error codes where off by 1.

Fixes: #90
@OrangeTux OrangeTux requested a review from jaapz June 7, 2020 08:32
@coveralls
Copy link

coveralls commented Jun 7, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 96.309% when pulling 5fdc3b8 on fix-error-code into 749d69f on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 95.861% when pulling 5fdc3b8 on fix-error-code into 749d69f on master.

jaapz
jaapz approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@jaapz jaapz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaapz jaapz merged commit dcf35a1 into master Jun 23, 2020
@jaapz jaapz deleted the fix-error-code branch June 23, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaapz jaapz jaapz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid error codes
3 participants
@OrangeTux @coveralls @jaapz