fix: check for non empty search arg

[Alexays]

Hi, @elliotcondon

In case we're using acf/fields/post_object/query and unsetted the s arg in order to use something like post__in this cause a warning.
Here's the fix 😃

[elliotcondon]

Hi @Alexays

Thanks for the PR and fix. I'm always interested in avoiding PHP errors, but would like to better understand the context when you are unsetting the search parameter. Are you performing some kind of custom search? Or are you preventing search completely?

[Alexays]

Hi @Alexays

Thanks for the PR and fix. I'm always interested in avoiding PHP errors, but would like to better understand the context when you are unsetting the search parameter. Are you performing some kind of custom search? Or are you preventing search completely?

We're unsetting the search parameter and set the post__in param in order to search by post ID/post URL directly.

Here's an example:

add_filter('acf/fields/post_object/query', array($this, 'alterQuery'), 10, 3);

public function alterQuery($args, $field, $post_id) {
        // Get search query
        $search = $args['s'];

        // If post id, return post asked
        if (is_numeric($search)) {
            $args['post__in'] = array((int) $search);
            unset($args['s']);
            return $args;
        }
       return $args
}

[elliotcondon]

Well that's a pretty good explanation! Thanks mate. Leave this with me, and I'll do my best to incorporate it into the next release.

With my dev workflow, I work on the PRO version, and then sync those changes down into the free one (not the other way around), so I technically won't merge in this PR.

Thanks again for raising the issue. I should have this fixed in 5.9.2

[elliotcondon]

Hi @Alexays. Quick update on this issue. I've manually implemented this in the PRO repository and will include this in the next release (5.9.2). Thanks again for your help. I'm looking forward to overhauling these AJAX queries in the near future!