WIP: refactoring and more checks in prince source #32

edoput · 2018-03-29T11:01:16Z

This will try to not break prince and make it more robust

under the directory prince (kind of ) everything is checked for bad malloc and kind of handled
reading the configuration provides hints for mistypes and such
logs to stderr and stdout are divided
add cmake build definitions
move headers to different directories
install binaries and libraries to /usr/local by default
source files with a high count of loc have been divided
more things behave correctly (unix style returns and errno)
prune some functions from source as it's not used
use meaningful names when using pointers and structs
remove shared pointer between plugins and prince handler

gabri94 · 2018-04-05T23:41:29Z

README.md


-Compile and install:
-`make && make install`
+## Unsing Prince with OONF


gabri94 · 2018-04-05T23:43:42Z

prince/conf/conf_c.json

@@ -3,7 +3,8 @@
 		"protocol": "oonf",
 		"host": "127.0.0.1",
 		"port": 8081 ,
-		"refresh": 1
+		"refresh": 1,
+               "timer_port": 1


timer port should be 2009 for oonf

- use types - more error messages - avoid exiting on unknown configuration keys

- more error checking on malloc - format nicely

- move structs and constructor/destructor to module - set up cmake for new module

this is very tricky as it requires freeing two more pointers in prince_handler_t and adding functions to create and free this new structs

- return 0 on success - be portable

- check for mallocs - check for return values

as there is a custom parser for topology data we don't need to supply it to a plugin

this will ensure that the graph parser is always created and freed from prince constructor and destructor

this will provide a way to filter on the errors types when trying to reconnect remove loading prototype of configurations

gabri94 requested changes Apr 5, 2018

View reviewed changes

edoput added 29 commits April 10, 2018 15:58

add cmake build definition, remove makefile

2b3333e

update readme

671cec6

create include directories for headers

3d63b8f

add install target to cmake

0f06ee9

switch to custom types for topology, node and prince_handler

4927b4c

use a common free_<type> approach in all our data structures

185c40d

move topology struct and functions to topology module

a52e5d1

format nicely parser.c

a3c3a01

format nicely control flow, add nicer errors and log messages

6ec7340

refactor prince_handler constructor

76a5233

print errors for new socker

cef2fff

format nicely socket, parser, config modules

82d3ddb

fix return code for main, print error when opening shared library

52ab80d

refactor config module

7e3f824

- use types - more error messages - avoid exiting on unknown configuration keys

define names for invalid structs and use them

cc4472e

format nicely functions in plugin interface header

41b41f6

explicitly state that netjson has been chosen as default

0de8513

order headers in oonf library

a7da579

refactor topology module

5f1c33a

- more error checking on malloc - format nicely

indent correctly

6ff80a9

rename module parser to topology_parser

03bba28

move plugin type declaration to common header

c8f4846

add missing get_initial_timers implementation to oonf library

f38e107

create load_plugin module

950d6f8

create prince_handler module

507d6a6

- move structs and constructor/destructor to module - set up cmake for new module

create config structs for graph and proto, make new modules

6ee1b6b

this is very tricky as it requires freeing two more pointers in prince_handler_t and adding functions to create and free this new structs

add graph_config and proto_config when creating a prince_handler

0e137cd

early return when supplied conf poiter is invalid

5029b32

implement loading of plugin functions

676b83d

edoput added 29 commits April 10, 2018 15:58

fix get_topology to behave as unix suppose

04d835c

free temporary prince_handler in config modules

554f03a

fix graph_parser header, format nicely source

74f1e9d

more checks in prince main on bad pointers

bbd372e

follow unix conventions

31c2dee

- return 0 on success - be portable

refactor for error checking

8e561f7

- check for mallocs - check for return values

parse netjson and add error messages for unknown keys

225754a

update error check in prince

1e68cc9

move test directory outside of prince

dc8ff10

more error checking in olsr and socket

f8c2dd9

remove graph_parser reference

88a1507

as there is a custom parser for topology data we don't need to supply it to a plugin

fix indentation issue

2f9a9a9

remove http_receive function as it's not used

99769eb

fix new_plugin_p signature

e4c1a3a

move creation of graph_parser in prince module

2572a91

this will ensure that the graph parser is always created and freed from prince constructor and destructor

add malloc check to brandes module

e25267a

move plugin creationg to prince_handler

b0602e3

remove duplicate file write

ee41c13

update prince_handler id from procedure

4d95dc0

implement valid_topo

fa23483

update error message for jsoninfo parser

9bc5d84

update find_node to return 0 on success

1a69a69

add exponential backoff on socket connecting

9b36fb2

handle errors when connecting

009025c

this will provide a way to filter on the errors types when trying to reconnect remove loading prototype of configurations

make get_initial_timer behave

9687d3e

set default timers when none are recovered

6941924

set protocol as olsrv1 in jsoninfo parser

46e9aa4

remove duplicate target

3101a7f

remove duplicate declaration in brandes

c59dc2f

gabri94 merged commit dfdda64 into AdvancedNetworkingSystems:master Apr 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: refactoring and more checks in prince source #32

WIP: refactoring and more checks in prince source #32

edoput commented Mar 29, 2018

gabri94 Apr 5, 2018

gabri94 Apr 5, 2018

WIP: refactoring and more checks in prince source #32

WIP: refactoring and more checks in prince source #32

Conversation

edoput commented Mar 29, 2018

gabri94 Apr 5, 2018

Choose a reason for hiding this comment

gabri94 Apr 5, 2018

Choose a reason for hiding this comment