Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Providers | Refactor "Manage Groups" section into a component #140

Closed
jfmdev opened this issue Dec 23, 2021 · 0 comments · Fixed by #145
Closed

Search Providers | Refactor "Manage Groups" section into a component #140

jfmdev opened this issue Dec 23, 2021 · 0 comments · Fixed by #145
Assignees
@pushpendraKh
Labels
code-refactoring Technical debt will be reduced
Milestone
v5.2

Comments

@jfmdev
Copy link
Contributor

jfmdev commented Dec 23, 2021

Similarly to how was done for the on #114, encapsulate all code related to from the "Manage Groups" section from the Search Providers tab (on the Options page) into a Svelte component (components/settings/providers/groups.svelte).

Related to #138 and #139
@jfmdev jfmdev added the code-refactoring Technical debt will be reduced label Dec 23, 2021
@jfmdev jfmdev added this to the v5.2 milestone Dec 23, 2021
@jfmdev jfmdev changed the title Settings | Refactor "Manage Groups" section into a component Search Providers | Refactor "Manage Groups" section into a component Dec 23, 2021
@jfmdev jfmdev mentioned this issue Dec 23, 2021
Closed
@pushpendraKh pushpendraKh self-assigned this Jan 4, 2022
pushpendraKh added a commit that referenced this issue Jan 4, 2022
@pushpendraKh
Issue-140 | Migrate Manage Groups to Svelte
9cbffdf 
fixes: #140
@pushpendraKh pushpendraKh mentioned this issue Jan 4, 2022
Merged
jfmdev added a commit that referenced this issue Jan 12, 2022
@jfmdev
Issue #140 - Minor code refactoring
4477f88
jfmdev added a commit that referenced this issue Jan 13, 2022
@pushpendraKh @jfmdev
Issue #140 - Migrate Manage Groups to Svelte (#145)
c01bf66 
* Issue-140 | Migrate Manage Groups to Svelte

fixes: #140

* fix: action on label and remove the numbers before groups

* Issue #140 - Minor code refactoring

Co-authored-by: Jose <jfmdev@gmail.com>
@jfmdev jfmdev mentioned this issue Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pushpendraKh pushpendraKh

Labels
code-refactoring Technical debt will be reduced
Projects
None yet
Milestone
v5.2
Development

Successfully merging a pull request may close this issue.

Issue #140 | Migrate Manage Groups to Svelte AdvancedThreatAnalytics/threat-analytics-search
2 participants
@jfmdev @pushpendraKh