Completed healer quest but unable to renew

Fixes #137

packages/game/src/commands/heal.ts

@@ -32,9 +32,9 @@ export const execute = async ({
       interaction.user
   )
 
-  const healer = getUserCharacter(interaction.user)
+  let character = getUserCharacter(interaction.user)
 
-  const result = heal(healer.id, target.id)
+  const result = heal({ healerId: character.id, targetId: target.id })
   if (!result) {
     interaction.editReply('No result. This should not happen.')
     return
@@ -45,21 +45,23 @@ export const execute = async ({
   }
   updateUserQuestProgess(interaction.user, 'healer', result.amount)
 
+  character = getUserCharacter(interaction.user)
+
   await interaction.editReply({
     embeds: [
       new MessageEmbed({
-        title: `${decoratedName(healer)} ${
-          healer.id === target.id
-            ? 'self healed'
-            : 'healed ' + decoratedName(target)
+        title: `${decoratedName(character)} healed ${
+          character.id === target.id ? '' : decoratedName(target)
         } for ${EmojiModifier('heal', result.amount)}`,
         fields: [
           hpBarField({
             character: target,
             adjustment: result.amount,
           }),
         ].concat(
-          healer.quests.healer ? questProgressField(healer.quests.healer) : []
+          character.quests.healer
+            ? questProgressField(character.quests.healer)
+            : []
         ),
       }).setImage(
         asset('fantasy', 'magic', 'a glowing hand applying healing magic').s3Url

packages/game/src/heal/heal.ts

@@ -8,12 +8,15 @@ import store from '@adventure-bot/game/store'
 import { healed } from '@adventure-bot/game/store/slices/characters'
 import { d6 } from '@adventure-bot/game/utils'
 
-export const heal = (
-  initiatorId: string,
+export function heal({
+  healerId,
+  targetId,
+}: {
+  healerId: string
   targetId: string
-): HealResult | undefined => {
-  if (isCharacterOnCooldown(initiatorId, 'heal')) return { outcome: 'cooldown' }
-  const healer = getCharacter(initiatorId)
+}): HealResult | undefined {
+  if (isCharacterOnCooldown(healerId, 'heal')) return { outcome: 'cooldown' }
+  const healer = getCharacter(healerId)
   if (!healer) return
   const targetBeforeHeal = getCharacter(targetId)
   if (!targetBeforeHeal) return

packages/game/src/quest/rewards/healerQuestReward.ts

@@ -1,12 +1,10 @@
 import { CommandInteraction } from 'discord.js'
 
-import { getUserCharacter } from '@adventure-bot/game/character'
 import { buffQuestReward, healerStatus } from '@adventure-bot/game/quest'
+import { quests } from '@adventure-bot/game/quest/quests'
 
 export const healerQuestReward = async (
   interaction: CommandInteraction
 ): Promise<void> => {
-  const quest = getUserCharacter(interaction.user).quests.healer
-  if (!quest) return
-  buffQuestReward(interaction, healerStatus, quest)
+  buffQuestReward(interaction, healerStatus, quests.healer)
 }