#202, #224 simplify configation - alternative to #6 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow more comfortable ini configuration like [configsection] value1=foo value2=bar value3=dummy [configsection.subsection] value1=foo value2=foo value3=foo value4=foo [configsection.subsection.subsubsection1] value1=foo value2=bar value3=blub value4=dummy [configsection.subsection.subsubsection2] value1=foo value2=bar value3=blub value4=dummy
change BaseConfiguration to use '.' as section delimiter by default without the ability to change it allow requesting and setting values and section of lower levels by using the subsection delimiter examples $section -> getSection($name='subSection.subSubSection'); $section -> setSection($name='subSection/subSubSection', $newSubsection);
|
|
||
| private function explodePath($name){ | ||
|
|
||
| $pathArray = explode('.',$name); |
There was a problem hiding this comment.
why dont you use $this->sectionDelimiter here instead of '.'?
There was a problem hiding this comment.
just a mistake. will be corrected
|
Used your suggestion to implement a solution as discussed in http://tracker.adventure-php-framework.org/view.php?id=224. Thus closing this request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an alternative to #6
as mentioned in http://tracker.adventure-php-framework.org/view.php?id=202#c455 it would be better if there is no need to apply another parameter when using the configuration.
I followed suggestion b) and use a fix delimiter in the baseConfiguration.