Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override payment method names #1380

Commits on Nov 13, 2023

  1. Configuration menu
    Copy the full SHA
    2de5c55 View commit details
    Browse the repository at this point in the history
  2. Add overridePaymentMethodName method in DropInConfiguration

    Add the necessary logic to override the name field of payment methods
    
    COAND-804
    araratthehero committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    39ecc10 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    78daf08 View commit details
    Browse the repository at this point in the history
  4. Modify overridePaymentMethodInformation implementation.

    Add tests for overridePaymentMethodInformation function.
    
    COAND-804
    araratthehero committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    3e7d66a View commit details
    Browse the repository at this point in the history
  5. Remove redundant DropInViewModelFactoryTest

    Clean up code
    
    COAND-804
    araratthehero committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    aaba2de View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Add release notes

    COAND-804
    
    diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
    index 5ba0f46de..04bbf7767 100644
    --- a/RELEASE_NOTES.md
    +++ b/RELEASE_NOTES.md
    @@ -1,21 +1,12 @@
     [//]: # (This file will be used for the release notes on GitHub when publishing.)
    -[//]: # (Types of changes: `Added` `Changed` `Deprecated` `Removed` `Fixed` `Security`)
    +[//]: # (Types of changes: `Breaking changes` `New` `Added` `Changed` `Deprecated` `Removed` `Fixed`)
     [//]: # (Example:)
     [//]: # (## Added)
     [//]: # ( - New payment method)
     [//]: # (## Changed)
     [//]: # ( - DropIn service's package changed from `com.adyen.dropin` to `com.adyen.dropin.services`)
    -[//]: # ( # Deprecated)
    +[//]: # (## Deprecated)
     [//]: # ( - Configurations public constructor are deprecated, please use each Configuration's builder to make a Configuration object)
    
    -## Fixed
    -- `@RestrictTo` annotations no longer cause false errors with Android Studio and Lint.
    -- Using the layout inspector or having view attribute inspection enabled in the developer options no longer causes a crash when viewing a payment method.
    -- Implementing the `:action` module no longer gives a duplicate class error caused by a duplicate namespace.
    -- For Drop-in, dismissing the gift card payment method no longer prevents further interaction.
    -
    -## Changed
    -- Dependency versions:
    -  | Name                                                                                                   | Version                       |
    -  |--------------------------------------------------------------------------------------------------------|-------------------------------|
    -  | [AndroidX Compose BoM](https://developer.android.com/jetpack/compose/bom/bom-mapping)                  | **2023.09.01**                |
    +## New
    +- You can now override payment method names in drop in by using `DropInConfiguration.Builder.overridePaymentMethodName(type, name)`
    araratthehero committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    a4a090b View commit details
    Browse the repository at this point in the history
  2. Address CR comments

    COAND-804
    araratthehero committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e44f359 View commit details
    Browse the repository at this point in the history