Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft proposal to update the Google Pay section of the sample application #1469

Merged
merged 21 commits into from
Feb 20, 2024
Merged

Draft proposal to update the Google Pay section of the sample application #1469

merged 21 commits into from
Feb 20, 2024

Commits on Dec 22, 2023

  1. Upgrade google pay library to 19.3.0-beta01

    @jreij
    jreij committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    6fb937a View commit details
    Browse the repository at this point in the history

  2. Update GooglePayComponent to support launching with activity result l… 

    …auncher
    @jreij
    jreij committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    7ec61ce View commit details
    Browse the repository at this point in the history

  3. Update Google Pay + views sample to use an activity result launcher

    @jreij
    jreij committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    ee4a2af View commit details
    Browse the repository at this point in the history

  4. Update Google Pay + compose sample to use an activity result launcher

    @jreij
    jreij committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    5ca5a77 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Upgrade google pay library to 19.3.0-beta01

    @jreij
    jreij committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    ba2864e View commit details
    Browse the repository at this point in the history

  2. Update GooglePayComponent to support launching with activity result l… 

    …auncher
    @jreij
    jreij committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    0d88572 View commit details
    Browse the repository at this point in the history

  3. Update Google Pay + views sample to use an activity result launcher

    @jreij
    jreij committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    f3183ca View commit details
    Browse the repository at this point in the history

  4. Update Google Pay + compose sample to use an activity result launcher

    @jreij
    jreij committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    7d02436 View commit details
    Browse the repository at this point in the history

  5. Add awaitTask extension to handle google pay's paymentDataTask

    @jreij
    jreij committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    18d8bd7 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Merge branch 'test/google_pay_beta' of https://github.com/Adyen/adyen… 

    …-android into test/google_pay_beta

# Conflicts:
#	googlepay/src/main/java/com/adyen/checkout/googlepay/internal/provider/GooglePayComponentProvider.kt
#	googlepay/src/main/java/com/adyen/checkout/googlepay/internal/ui/DefaultGooglePayDelegate.kt
    @JlUgia
    JlUgia committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    325ec9a View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Merge branch 'test/google_pay_beta' of https://github.com/Adyen/adyen… 

    …-android into test/google_pay_beta

# Conflicts:
#	googlepay/src/main/java/com/adyen/checkout/googlepay/internal/ui/DefaultGooglePayDelegate.kt
#	gradle/verification-metadata.xml
    @JlUgia
    JlUgia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    a24f4aa View commit details
    Browse the repository at this point in the history

  2. Distinguish between state and events

    @JlUgia
    JlUgia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    dea023f View commit details
    Browse the repository at this point in the history

  3. Hoist state to remove the dependency from the viewModel in the Compos… 

    …able
    @JlUgia
    JlUgia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    edeb0b1 View commit details
    Browse the repository at this point in the history

  4. If possible instantiate the googlePayComponent only once

    @JlUgia
    JlUgia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    afe1627 View commit details
    Browse the repository at this point in the history

  5. Using sealed classes instead of nullable parameters in the state enab… 

    …les avoiding the nullifying cycle after actions are handled
    @JlUgia
    JlUgia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    09c5024 View commit details
    Browse the repository at this point in the history

  6. The start google pay action seems to make an unnecessary trip and bac… 

    …k to the viewModel. Instead, the payment operation can be started right away
    @JlUgia
    JlUgia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    cf5f167 View commit details
    Browse the repository at this point in the history

  7. The payment result may not need to go back to the view (as long as th… 

    …e call with the result does not depend on the Google Pay component)
    @JlUgia
    JlUgia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    bf90ad8 View commit details
    Browse the repository at this point in the history

  8. The result of loadPaymentData, if successful, is not null by contract

    @JlUgia
    JlUgia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2fd3380 View commit details
    Browse the repository at this point in the history

  9. Styles and imports

    @JlUgia
    JlUgia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2f6f6c5 View commit details
    Browse the repository at this point in the history

  10. Make naming consistent with other classes

    @JlUgia
    JlUgia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8b7597d View commit details
    Browse the repository at this point in the history

  11. Use the Google Pay component member to handle the payment result

    @JlUgia
    JlUgia committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    4348459 View commit details
    Browse the repository at this point in the history