Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3ds2 sdk #1585

Merged
merged 7 commits into from Apr 29, 2024
Merged

Update 3ds2 sdk #1585

merged 7 commits into from Apr 29, 2024

Conversation

OscarSpruit
Copy link
Contributor

Description

Update 3ds2 sdk to 2.2.17

Checklist

  • Code is unit tested
  • Changes are tested manually
  • Link to related issues
  • Add relevant labels to PR

COAND-886

@OscarSpruit OscarSpruit added the Dependencies [PRs only] Indicates a dependency update label Apr 26, 2024
@OscarSpruit OscarSpruit requested a review from a team as a code owner April 26, 2024 12:15
@OscarSpruit OscarSpruit linked an issue Apr 26, 2024 that may be closed by this pull request
OscarSpruit and others added 7 commits April 29, 2024 08:47
The new version of the 3DS2 SDK doesn't accept these parameters to be nullable anymore.

COAND-886
COAND-886
The instance fields throws an exception in unit tests, so we have to fake this field away.

COAND-886
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
75.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@OscarSpruit OscarSpruit merged commit 6aef6f7 into develop Apr 29, 2024
7 of 8 checks passed
@OscarSpruit OscarSpruit deleted the update-3ds2-sdk branch April 29, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies [PRs only] Indicates a dependency update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Adyen 3DS2 to v2.2.16+ to solve CVE-2023-33201
2 participants