Migrate to non-transitive R classes #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarSpruit
force-pushed
the
refactor/non-transitive-r
branch
from
52c5344
to
378cad7
Compare
OscarSpruit
added
the
Chore
jreij
reviewed
May 2, 2024
I thought it doesn't, but let's test it out |
OscarSpruit
force-pushed
the
fix/sonar-build-time
branch
from
d410c6d
to
ba91dd8
Compare
OscarSpruit
force-pushed
the
refactor/non-transitive-r
branch
from
378cad7
to
9cb9edf
Compare
OscarSpruit
force-pushed
the
refactor/non-transitive-r
branch
from
9cb9edf
to
dd776a3
Compare
|
jreij
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate to non-transitive R classes. R classes must now by fully referenced and modules need an explicit dependency on a library of which the R class is from.
./gradlew clean assDeb --no-build-cachewent from 1m 2s to 45s locally. Combined with KSP it will be even better