43 Deployment #44
43 Deployment #44
Conversation
extension/k8s/values.yaml
Outdated
| path: '' | ||
|
|
||
|
|
||
| readinessProbe: |
There was a problem hiding this comment.
Do we have a TODO for that?
| } catch (e) { | ||
| console.error('Error when creating interface interaction custom type, skipping...', JSON.stringify(e)) | ||
| logger.error('Error when creating interface interaction custom type, skipping...', JSON.stringify(e)) |
There was a problem hiding this comment.
Do not stringify an error. Proper format with bunyan would be:
logger.error(e, "My custom message")
There was a problem hiding this comment.
Please also check al other places in the code.
| await ctpClient.create(ctpClient.builder.types, paymentCustomType) | ||
| logger.info('Successfully created payment custom type') |
There was a problem hiding this comment.
Does the logger also outputs the tenant info?
There was a problem hiding this comment.
Right now we don't have multitenancy support, so it doesn't have tenant info.
notification/Dockerfile
Outdated
| @@ -0,0 +1,13 @@ | |||
| FROM mhart/alpine-node:10 | |||
There was a problem hiding this comment.
Just an info: GCP functions support currently only following node versions: 6, 8
There was a problem hiding this comment.
node 10 is now in beta: https://cloud.google.com/functions/docs/concepts/nodejs-10-runtime
notification/k8s/values.yaml
Outdated
| # memory: '1Gi' #equivalent to 2GiB | ||
| # limits: | ||
| # cpu: '300m' #30% of CPU time on 1 GCP Core | ||
| # memory: '1Gi' #equivalent to 2GB |
There was a problem hiding this comment.
Why no resources requests/limits are set?
There was a problem hiding this comment.
We are in a faze of figuring it out 🙂
| }, | ||
| "required": true, | ||
| "type": { | ||
| "name": "String" |
There was a problem hiding this comment.
There is also date/time type. Is String on purpose here?
| if (body.results.length === 0) { | ||
| logger.debug('Creating interface interaction') | ||
| await ctpClient.create(ctpClient.builder.types, interfaceInteractionType) | ||
| logger.info('Successfully created an interfaceInteraction type') |
There was a problem hiding this comment.
I would output the key of the type too
There was a problem hiding this comment.
As stated above, I would change it in a different task: #8
| break | ||
| } catch (err) { | ||
| } catch (e) { |
There was a problem hiding this comment.
Pls add a test for this catch error case.
There was a problem hiding this comment.
there is a test and it was failing. Fixed the issue. Thanks
Fixes: #43