Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Xcode 12 Compiler Error "FormViewController" #257

Closed
omerozk opened this issue Nov 5, 2020 · 3 comments
Closed

[BUG] Xcode 12 Compiler Error "FormViewController" #257

omerozk opened this issue Nov 5, 2020 · 3 comments

Comments

@omerozk
Copy link

omerozk commented Nov 5, 2020

Describe the bug

On Xcode 12 we are facing a build error as we are implementing Adyen and another lib called Eureka (https://github.com/xmartlabs/Eureka).

Both lib are exposing a class called FormViewController. With the new build process of Xcode 12, ObjC generated headers are now entering in conflict which make the compilation fail.

Here you can find more information about this issue: https://developer.apple.com/forums/thread/658012
similar issue on Kingfisher library (conflict with alamofire SessionDelegate): onevcat/Kingfisher#1530

To Reproduce
Steps to reproduce the behavior:

  1. launch Xcode 12
  2. Add Pods Adyen and Eureka to your podfile
  3. install pods
  4. build your project
  5. this following error occur on complilation:

FormViewController has different definitions in different modules; first difference is definition in module 'Adyen.Swift' found method

Expected behavior
Successful build!

Smartphone (please complete the following information):

  • Device: [iPhone XS]
  • OS: [14]
  • SDK Version [3.7.0]

Additional context

2 ways to fix this:

  • Do not generate headers for ObjC. SWIFT_INSTALL_OBJC_HEADER = NO
  • Set an explicit prefix for ObjC which will resolve namespacing
@objc(AdyenFormViewController)
public final class FormViewController { ... }

I think the most adapted approach, if ObjC support is required, will be the second approach to fix this issue

@omerozk omerozk added the bug label Nov 5, 2020
@mohammedDehairy
Copy link
Contributor

Hi @omerozk ,

Thanks for the report!.

We'll look into it and fix it in the next release.

@descorp
Copy link
Contributor

descorp commented Nov 23, 2020

Hey @omerozk

This PR should resolve it.

@descorp
Copy link
Contributor

descorp commented Nov 24, 2020

3.8.0 is released!

I am going to close this ticket for now.
Feel free to respond in this thread or provide any additional feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants