Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Kingfisher with Alamofire - SessionDelegate - Xcode 12 #1530

Closed
3 tasks done
mrazam110 opened this issue Sep 23, 2020 · 4 comments · Fixed by #1532
Closed
3 tasks done

Use of Kingfisher with Alamofire - SessionDelegate - Xcode 12 #1530

mrazam110 opened this issue Sep 23, 2020 · 4 comments · Fixed by #1532

Comments

@mrazam110
Copy link

mrazam110 commented Sep 23, 2020

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

Issue Description

Showing All Errors Only
'SessionDelegate' has different definitions in different modules; first difference is definition in module 'Alamofire.Swift' found method

Xcode 12:
Add Pods of Alamofire and Kingfisher
Build Project

@mrazam110 mrazam110 changed the title Use of Kingfisher with Alamofire - SessionDelegate Use of Kingfisher with Alamofire - SessionDelegate - Xcode 12 Sep 23, 2020
@christophercotton
Copy link

christophercotton commented Sep 23, 2020

I ended up forking Kingfisher and just applying the name space for the SessionDelegate.

TrueRowing@248b225

@objc(KFSessionDelegate)
 class SessionDelegate: NSObject {

@onevcat
Copy link
Owner

onevcat commented Sep 24, 2020

I don't have this issue when trying in a sample project installing both the latest versions of Kingfisher (5.15.3) and Alamofire (5.2.2). It might be either a version issue or a local project setting problem. And it is not strange that CocoaPods is generating the ObjC compatible header by default, so it is still triggering #1517.

@christophercotton That fix is nice and I will also add it to this repo so we can solve it in any dependency manager.

@christophercotton
Copy link

@onevcat it happens with Alamofire 4.x. Which sadly we are still on for one product. Though it would probably conflict with any other project that had a SessionDelegate. Thanks for adding the change.

@mrazam110
Copy link
Author

Resolved in 5.15.4
Thanks @onevcat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants