Remove hard validation for additional and optional fields #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wboereboom
requested changes
May 16, 2023
src/main/java/com/adyen/model/balancecontrol/BalanceTransferRequest.java
Outdated
Show resolved
Hide resolved
|
I think this also warrants a unit test to verify new behavior |
Co-authored-by: Wouter Boereboom <62436079+wboereboom@users.noreply.github.com>
Co-authored-by: Wouter Boereboom <62436079+wboereboom@users.noreply.github.com>
@wboereboom we already have tests for oneOf model (de)serialization, which is the main concern for this fix. In order for them to pass I needed to leave the required parameter validation (basically this is the only requirement for the oneOf models to properly deserialize I found). Afterwards I also checked that for the oneOf model deserialization the warning is supressed. Is there any other scenarios that we need to test you think? |
wboereboom
approved these changes
May 22, 2023
wboereboom
approved these changes
May 22, 2023
AlexandrosMor
approved these changes
May 22, 2023
jillingk
added
Bug report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove hard validation for additional/optional fields so that added parameters will not break integrations. Also had to ignore the logger for oneOf fields (as that validation will fail always).
fixes #1024