Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITT-572] Process webhooks with Optional field #1051

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Conversation

jillingk
Copy link
Contributor

@jillingk jillingk commented Jun 8, 2023

Description
Implemented @michaelpaul's feedback regarding the webhooks. This way merchants get use the Optional fields to check the webhook type.

@jillingk jillingk requested a review from a team as a code owner June 8, 2023 09:19
Copy link
Contributor

@michaelpaul michaelpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some small tweaks.

README.md Outdated Show resolved Hide resolved
src/test/java/com/adyen/WebhookTest.java Outdated Show resolved Hide resolved
jillingk and others added 2 commits June 8, 2023 12:56
Co-authored-by: Michael Paul <michael@michaelpaul.com.br>
Co-authored-by: Michael Paul <michael@michaelpaul.com.br>
@jillingk jillingk requested review from michaelpaul, a team and wboereboom June 8, 2023 11:22
@jillingk jillingk merged commit aab24c5 into develop Jun 8, 2023
5 checks passed
@jillingk jillingk deleted the ITT-572feedback branch June 8, 2023 12:32
@wboereboom wboereboom added the Fix Indicates a bug fix label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants