Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PW-2415 Added Jackson annotations in models for serialization #423

Merged
merged 7 commits into from Sep 23, 2020
Merged

PW-2415 Added Jackson annotations in models for serialization #423

merged 7 commits into from Sep 23, 2020

Conversation

saquibsayyad
Copy link
Contributor

Description
Added Jackson annotations in the models so that they can be serialized the same way as GSON

Fixed issue:
#340

@saquibsayyad
PW-2415 Added Jackson annotations in models and tests to make sure al…
bb28934 
…l models are serialized the same way in Jackson and GSON both.
@coveralls
Copy link

coveralls commented Sep 17, 2020 •
edited

Coverage Status

Coverage increased (+2.6%) to 27.553% when pulling 2951a94 on PW-2415 into 21bf2d9 on develop.

andrei-dediu
andrei-dediu previously approved these changes Sep 23, 2020
View reviewed changes
rkewlani
rkewlani reviewed Sep 23, 2020
View reviewed changes
pom.xml Outdated
@@ -25,6 +25,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<jackson.version>2.11.2</jackson.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please use 2.9.7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

andrei-dediu
andrei-dediu previously approved these changes Sep 23, 2020
View reviewed changes
Aleffio
Aleffio previously approved these changes Sep 23, 2020
View reviewed changes
rkewlani
rkewlani previously approved these changes Sep 23, 2020
View reviewed changes
@saquibsayyad saquibsayyad merged commit e74e64f into develop Sep 23, 2020
@saquibsayyad saquibsayyad deleted the PW-2415 branch September 23, 2020 15:06
@saquibsayyad saquibsayyad mentioned this pull request Sep 28, 2020
Merged
@deepu105
Copy link

@saquibsayyad @andrei-dediu seems like annotations are missing for SepaDirectDebitDetails, any reason this class is needed as the DefaultPaymentMethodDetails seems to have this field. If not required we should mark it as deprecated IMO

@saquibsayyad
Copy link
Contributor Author

Hi @deepu105 ,

SepaDirectDebitDetails has field name same as in the json representation, so Jackson annotations won't be required.
DefaultPaymentMethodDetails is part of old implementation, we will be deprecating it in future.

Thanks,
Saquib

@deepu105
Copy link

But the data sent from the client side still uses the old format so this doesn't work at the moment and I would assume changing how the front end sends data is a breaking change?

@saquibsayyad
Copy link
Contributor Author

Hi @deepu105,

Both the formats are working for now. sepa.ibanNumber and sepa.ownerName fields are already deprecated internally and will be removed later. It is replaced by iban and ownerName.
Thanks,
Saquib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleffio Aleffio Aleffio approved these changes

@andrei-dediu andrei-dediu andrei-dediu approved these changes

@martinsrenato martinsrenato Awaiting requested review from martinsrenato

@rikterbeek rikterbeek Awaiting requested review from rikterbeek

@rkewlani rkewlani Awaiting requested review from rkewlani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saquibsayyad @coveralls @deepu105 @Aleffio @rkewlani @andrei-dediu