Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend signatory support (Account API) #599

Merged
merged 5 commits into from Aug 19, 2021

Conversation

RickWieman
Copy link
Contributor

@RickWieman RickWieman commented Aug 9, 2021

Description

  • Add the /deleteSignatories endpoint to the Account API
  • Add the signatoryCode to the DocumentDetail (/uploadDocument endpoint)
  • Add KYCSignatoryCheckResult in KYCVerificationResult

The implementation of signatories is practically identical to that of shareholders.

Tested scenarios

  • Added test cases for new DeleteSignatory service
  • Manually checked the /uploadDocument with signatoryCode
  • Manually tested the new DeleteSignatory service
  • Updated the ACCOUNT_HOLDER_UPDATED mock notification to v6, so that we can test the KYCSignatoryCheckResult.

Fixed issue: N/A.

@coveralls
Copy link

coveralls commented Aug 9, 2021

Coverage Status

Coverage increased (+0.02%) to 29.916% when pulling 34a12f8 on RickWieman:extend-signatory-support into ba24e30 on Adyen:develop.

Aleffio
Aleffio previously approved these changes Aug 12, 2021
And update the ACCOUNT_HOLDER_UPDATED mock notification to v6 so that we can test this.
wboereboom
wboereboom previously approved these changes Aug 19, 2021
@wboereboom wboereboom merged commit 9382331 into Adyen:develop Aug 19, 2021
@wboereboom wboereboom mentioned this pull request Aug 19, 2021
@RickWieman RickWieman deleted the extend-signatory-support branch August 20, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants