New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pw 5482/update checkout api v68 #625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wboereboom
requested review from
abhilash-adyen,
Aleffio,
AlexandrosMor,
martinsrenato,
rkewlani and
saquibsayyad
as code owners
September 29, 2021 09:18
Aleffio
reviewed
Sep 29, 2021
src/main/java/com/adyen/model/checkout/CreateCheckoutSessionRequest.java
Show resolved
Hide resolved
Aleffio
reviewed
Sep 30, 2021
|
||
public static final String SERIALIZED_NAME_APPLICATION_INFO = "applicationInfo"; | ||
@SerializedName(SERIALIZED_NAME_APPLICATION_INFO) | ||
private ApplicationInfo applicationInfo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double check if ApplicationInfo is correctly populated or if we need to do the same as PaymentsRequest below?
adyen-java-api-library/src/main/java/com/adyen/model/checkout/PaymentsRequest.java
Line 201 in a4b2c05
applicationInfo = new ApplicationInfo(); |
Aleffio
approved these changes
Sep 30, 2021
Morerice
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Checkout version to v68 & added checkout sessions endpoint