-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECP-8861] Orders with failed authorisation can't be canceled #2404
Comments
I have fixed this by applying a patch with these changes, but it's something that should be addressed in the Adyen module directly:
|
Hi @marinagociulybe, I have tried to reproduce this with the given steps and I wasn't able to reproduce it, can you check it and let me know if there is any missing step? And besides that we need Also we don't save failed authorizations in |
Hi @hossam-adyen, indeed no authorizations are saved in
|
Hi @marinagociulybe, in case of failure payment, you should see a Can you tell what is the current state of those orders? for this case we are expecting them to be in |
@marinagociulybe you can also check if you set the |
@hossam-adyen, I can confirm that the Here's the flow I was seeing with these orders:
For the 3D secure process, I would not expect the order to show up directly as canceled in Magento, but to be canceled after that authentication process has failed. |
Hi @marinagociulybe, thanks lot for your insights, I was able to reproduce this issue when I set here is the fix PR #2479 Thanks for your valuable contribution |
@hossam-adyen, thanks for the update! Indeed, on this project |
Hello @hossam-adyen, do you have any update on this issue? We are seeing this affect some clients running version We are applying the following fix as a patch in the + /**
+ * Fix for failed auth cancellation bug
+ * @see https://github.com/Adyen/adyen-magento2/issues/2404
+ */
+ if (empty($requests['body']) && empty($pspReferences)) {
+ // PSP reference not found during cancellation, use PSP associated to order payment
+ $requests['body'][] = [
+ "paymentPspReference" => $payment->getCcTransId(),
+ "reference" => $order->getOrderIncrementId(),
+ "merchantAccount" => $merchantAccount
+ ];
+ }
return $requests; Please let me know if you have made any progress on this on your end, we are keen on implementing a more robust solution. Thanks! |
Describe the bug
Since we upgraded the module to the latest 8 version, orders with failed authorisation have remained stuck in payment review and are not being canceled when processing the Adyen notification. There is a generic message "The order failed to update: Transaction has been declined. Please try again later.", that I think I've been able to track to the changes introduced in this PR: https://github.com/Adyen/adyen-magento2/pull/2227/files
To Reproduce
Steps to reproduce the behavior:
but the Magento order is not canceled, it's just updated with a comment saying: "The order failed to update: Transaction has been declined. Please try again later."
Expected behavior
Magento order should get canceled.
Magento version
5.4.6-p3
Plugin version
8.22.5
Additional context
I've tracked this issue and it seems to be due to the changes introduced in this PR: https://github.com/Adyen/adyen-magento2/pull/2227/files
After that was added, the PSP references used to build the cancel request have started to be determined based on
adyen_order_payment
table entries:https://github.com/Adyen/adyen-magento2/pull/2227/files#diff-51b8cf2ebb2e0050bf1d10b97464bac8a567c6ac9cf148bb0a7a24b89432a3d9R56
But the issue is that with orders failing 3ds authentication, there is no entry in the
adyen_order_payment
table and this used to work because the PSP reference was fetched from the Magento payment:https://github.com/Adyen/adyen-magento2/pull/2227/files#diff-51b8cf2ebb2e0050bf1d10b97464bac8a567c6ac9cf148bb0a7a24b89432a3d9L35
The text was updated successfully, but these errors were encountered: