Update PaymentMethods.php #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an \Adyen\ConnectionException catch in case the curl request failed (if the live endPoint is misconfigured)
Prunecreation
requested review from
acampos1916,
AlexandrosMor,
michaelpaul,
Morerice,
peterojo,
rikterbeek and
tnaber
as code owners
acampos1916
reviewed
Feb 3, 2022
acampos1916
requested changes
Feb 3, 2022
There was a problem hiding this comment.
Thanks for this contribution @Prunecreation, I made a small suggestion for consistency.
Co-authored-by: Ángel Campos <acampos1916@gmail.com>
acampos1916
approved these changes
Feb 3, 2022
peterojo
approved these changes
Feb 3, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an \Adyen\ConnectionException catch in case the curl request failed (if the live endPoint is misconfigured)
Description
If the Live endPoint is misconfigured in the Magento2 module Backoffice, on the checkout page the CURL request to retrieve Adyen Payment raise an \Adyen\ConnectionException, but the getPaymentMethodsResponse in Helper/PaymentMethods.php is only catching \Adyen\AdyenException => so the Ajax call never return response and the checkout freeze when getting payment method.
Tested scenarios
Fixed issue: add an \Adyen\ConnectionException catch to handle failed CURL request